third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp - Issue 2181243002: Move ThreadableLoader to Oilpan heap (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

Issue 2181243002: Move ThreadableLoader to Oilpan heap (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-bridge-peer-in-worker-threadable-loader

Patch Set: fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp ('K') | « third_party/WebKit/Source/modules/notifications/NotificationImageLoader.h ('k') | third_party/WebKit/Source/web/AssociatedURLLoader.h » ('j') | third_party/WebKit/Source/web/AssociatedURLLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp b/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

index 298931c6c9cc0bdeeace13f2f9ff74390874b9ba..530aee3d338b7529ad0aed1f37fa86912648c35f 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

@@ -65,11 +65,7 @@ void NotificationImageLoader::stop()

m_stopped = true;

if (m_threadableLoader) {

m_threadableLoader->cancel();

- // WorkerThreadableLoader keeps a Persistent<WorkerGlobalScope> to the

- // ExecutionContext it received in |create|. Kill it to prevent

- // reference cycles involving a mix of GC and non-GC types that fail to

- // clear in ThreadState::cleanup.

- m_threadableLoader.reset();

+ m_threadableLoader = nullptr;

}