Expose imageSmothing attributes in OffscreenCanvas 2D context

Expose imageSmothing attributes in OffscreenCanvas 2D context

BUG=631825
Committed: https://crrev.com/91dd30b813c86bb4a101cb080269315d0e679b02
Cr-Commit-Position: refs/heads/master@{#408204}

[Justin Novosad, 2016-07-26 22:21:05]

junov@chromium.org changed reviewers:
+ xlai@chromium.org

[Justin Novosad, 2016-07-26 22:21:05]

PTAL

[xlai (Olivia), 2016-07-27 14:18:04]

https://codereview.chromium.org/2181183003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-imageSmoothing.html
(right):

https://codereview.chromium.org/2181183003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-imageSmoothing.html:28:
ctx.drawImage(image, 6, 0);
I'm just wondering: why you drawImage to position (6, 0) instead of (5, 0)?
Isn't the image a 5X5 rectangle?

[Justin Novosad, 2016-07-27 15:39:37]

On 2016/07/27 14:18:04, xlai (Olivia) wrote:
>
https://codereview.chromium.org/2181183003/diff/20001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-imageSmoothing.html
> (right):
> 
>
https://codereview.chromium.org/2181183003/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-imageSmoothing.html:28:
> ctx.drawImage(image, 6, 0);
> I'm just wondering: why you drawImage to position (6, 0) instead of (5, 0)?
> Isn't the image a 5X5 rectangle?

To have a space between the images so it is obvious where one ends and the other
begins

[Justin Novosad, 2016-07-27 17:33:34]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 17:33:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Novosad, 2016-07-27 17:35:43]

New patch. fixed layout test issues

[xlai (Olivia), 2016-07-27 17:38:56]

https://codereview.chromium.org/2181183003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2181183003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:62: crbug.com/593514
virtual/gpu/fast/canvas/OffscreenCanvas-2d-imageSmoothing-in-worker.html [
Failure ]
Hmmm, is there a strong motivation to expose imageSmoothing on OffscreenCanvas
when it actually doesn't work at this moment?

[Justin Novosad, 2016-07-27 18:41:38]

On 2016/07/27 17:38:56, xlai (Olivia) wrote:
>
https://codereview.chromium.org/2181183003/diff/40001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/TestExpectations (right):
> 
>
https://codereview.chromium.org/2181183003/diff/40001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/TestExpectations:62: crbug.com/593514
> virtual/gpu/fast/canvas/OffscreenCanvas-2d-imageSmoothing-in-worker.html [
> Failure ]
> Hmmm, is there a strong motivation to expose imageSmoothing on OffscreenCanvas
> when it actually doesn't work at this moment?

What do you mean? it works fine.
The failure expectation is just like the other ones above. Caused by the fact
that OffscreenCanvas does not really use the GPU under virtual/gpu, and
therefore hase dicrepancied with the -expected.html

[Justin Novosad, 2016-07-27 18:42:14]

On 2016/07/27 18:41:38, Justin Novosad wrote:
> On 2016/07/27 17:38:56, xlai (Olivia) wrote:
> >
>
https://codereview.chromium.org/2181183003/diff/40001/third_party/WebKit/Layo...
> > File third_party/WebKit/LayoutTests/TestExpectations (right):
> > 
> >
>
https://codereview.chromium.org/2181183003/diff/40001/third_party/WebKit/Layo...
> > third_party/WebKit/LayoutTests/TestExpectations:62: crbug.com/593514
> > virtual/gpu/fast/canvas/OffscreenCanvas-2d-imageSmoothing-in-worker.html [
> > Failure ]
> > Hmmm, is there a strong motivation to expose imageSmoothing on
OffscreenCanvas
> > when it actually doesn't work at this moment?
> 
> What do you mean? it works fine.
> The failure expectation is just like the other ones above. Caused by the fact
> that OffscreenCanvas does not really use the GPU under virtual/gpu, and
> therefore hase dicrepancied with the -expected.html

The non-gpu flavor of the test passes/

[xlai (Olivia), 2016-07-27 18:51:58]

On 2016/07/27 18:42:14, Justin Novosad wrote:
> On 2016/07/27 18:41:38, Justin Novosad wrote:
> > On 2016/07/27 17:38:56, xlai (Olivia) wrote:
> > >
> >
>
https://codereview.chromium.org/2181183003/diff/40001/third_party/WebKit/Layo...
> > > File third_party/WebKit/LayoutTests/TestExpectations (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2181183003/diff/40001/third_party/WebKit/Layo...
> > > third_party/WebKit/LayoutTests/TestExpectations:62: crbug.com/593514
> > > virtual/gpu/fast/canvas/OffscreenCanvas-2d-imageSmoothing-in-worker.html [
> > > Failure ]
> > > Hmmm, is there a strong motivation to expose imageSmoothing on
> OffscreenCanvas
> > > when it actually doesn't work at this moment?
> > 
> > What do you mean? it works fine.
> > The failure expectation is just like the other ones above. Caused by the
fact
> > that OffscreenCanvas does not really use the GPU under virtual/gpu, and
> > therefore hase dicrepancied with the -expected.html
> 
> The non-gpu flavor of the test passes/

Ah I see...Then it lgtm.

[Justin Novosad, 2016-07-27 18:55:01]

The CQ bit was unchecked by junov@chromium.org

[Justin Novosad, 2016-07-27 18:55:01]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2016-07-27 18:55:03]

The CQ bit was unchecked by junov@chromium.org

[commit-bot: I haz the power, 2016-07-27 18:55:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Novosad, 2016-07-27 18:55:09]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2016-07-27 18:55:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 18:58:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-27 18:59:48]

Description was changed from

==========
Expose imageSmothing attributes in OffscreenCanvas 2D context

BUG=631825
==========

to

==========
Expose imageSmothing attributes in OffscreenCanvas 2D context

BUG=631825

Committed: https://crrev.com/91dd30b813c86bb4a101cb080269315d0e679b02
Cr-Commit-Position: refs/heads/master@{#408204}
==========

[commit-bot: I haz the power, 2016-07-27 18:59:49]

Patchset 3 (id:??) landed as
https://crrev.com/91dd30b813c86bb4a101cb080269315d0e679b02
Cr-Commit-Position: refs/heads/master@{#408204}