Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 2181163002: media: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 4 months ago by vmpstr
Modified:
4 years, 4 months ago
Reviewers:
DaleCurtis
CC:
avayvod+watch_chromium.org, chromium-reviews, danakj, feature-media-reviews_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jasonroberts+watch_google.com, miu+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, toyoshim+midi_chromium.org, xjz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=dalecurtis@chromium.org BUG=554600 Committed: https://crrev.com/7c035fee8e8c3c0667923a161253a13594ed021c Cr-Commit-Position: refs/heads/master@{#407699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -31 lines) Patch
M media/base/mac/videotoolbox_helpers.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/cast/sender/audio_encoder.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M media/cast/sender/h264_vt_encoder.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M media/cast/sender/h264_vt_encoder_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/vt_video_encode_accelerator_mac.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M media/midi/midi_manager_android.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M media/midi/midi_manager_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vmpstr
Please take a look.
4 years, 4 months ago (2016-07-26 01:09:18 UTC) #1
DaleCurtis
lgtm
4 years, 4 months ago (2016-07-26 01:10:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181163002/1
4 years, 4 months ago (2016-07-26 01:21:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 03:34:46 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 03:38:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c035fee8e8c3c0667923a161253a13594ed021c
Cr-Commit-Position: refs/heads/master@{#407699}

Powered by Google App Engine
This is Rietveld 408576698