Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: media/midi/midi_manager_android.cc

Issue 2181163002: media: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/gpu/vt_video_encode_accelerator_mac.cc ('k') | media/midi/midi_manager_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/midi/midi_manager_android.cc
diff --git a/media/midi/midi_manager_android.cc b/media/midi/midi_manager_android.cc
index 2bd4d804e53468bf0473b9754623341d81103e41..617daeb500dc853cc6c55740db5726ba99dcd6e4 100644
--- a/media/midi/midi_manager_android.cc
+++ b/media/midi/midi_manager_android.cc
@@ -106,14 +106,14 @@ void MidiManagerAndroid::OnAttached(JNIEnv* env,
void MidiManagerAndroid::OnDetached(JNIEnv* env,
const JavaParamRef<jobject>& caller,
const JavaParamRef<jobject>& raw_device) {
- for (const auto& device : devices_) {
+ for (auto* device : devices_) {
if (device->HasRawDevice(env, raw_device)) {
- for (const auto& port : device->input_ports()) {
+ for (auto* port : device->input_ports()) {
DCHECK(input_port_to_index_.end() != input_port_to_index_.find(port));
size_t index = input_port_to_index_[port];
SetInputPortState(index, MIDI_PORT_DISCONNECTED);
}
- for (const auto& port : device->output_ports()) {
+ for (auto* port : device->output_ports()) {
DCHECK(output_port_to_index_.end() != output_port_to_index_.find(port));
size_t index = output_port_to_index_[port];
SetOutputPortState(index, MIDI_PORT_DISCONNECTED);
@@ -123,7 +123,7 @@ void MidiManagerAndroid::OnDetached(JNIEnv* env,
}
void MidiManagerAndroid::AddDevice(std::unique_ptr<MidiDeviceAndroid> device) {
- for (auto& port : device->input_ports()) {
+ for (auto* port : device->input_ports()) {
// We implicitly open input ports here, because there are no signal
// from the renderer when to open.
// TODO(yhirano): Implement open operation in Blink.
@@ -142,7 +142,7 @@ void MidiManagerAndroid::AddDevice(std::unique_ptr<MidiDeviceAndroid> device) {
device->GetProductName(),
device->GetDeviceVersion(), state));
}
- for (const auto& port : device->output_ports()) {
+ for (auto* port : device->output_ports()) {
const size_t index = all_output_ports_.size();
all_output_ports_.push_back(port);
« no previous file with comments | « media/gpu/vt_video_encode_accelerator_mac.cc ('k') | media/midi/midi_manager_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698