Moving Findit variable builder to experimental high-end bot

Moving Findit variable builder to experimental high-end bot

BUG=631251
Committed: https://chromium.googlesource.com/chromium/tools/build/+/ce4a301430a22466ef81e99847939bfff7f30e20

[lijeffrey, 2016-07-25 23:01:53]

lijeffrey@chromium.org changed reviewers:
+ iannucci@chromium.org, sergeyberezin@chromium.org

[lijeffrey, 2016-07-25 23:01:54]

Hey guys,

Moving 1 Findit variable builder to a newly-added high-end windows machine with
32 cores to see if there's any performance gains. PTAL when you have the chance

Thanks,
Jeff

[Sergey Berezin, 2016-07-26 00:14:44]

LGTM + comments (one optional nit, one important comment).

https://codereview.chromium.org/2181143002/diff/1/masters/master.tryserver.ch...
File masters/master.tryserver.chromium.win/slaves.cfg (right):

https://codereview.chromium.org/2181143002/diff/1/masters/master.tryserver.ch...
masters/master.tryserver.chromium.win/slaves.cfg:8: build=False):
nit: this may be better served by prefix='vm', and just specifying the correct
prefix at the call site.

In fact, gce is not used it this file (we don't have GCE windows bots). So
another option is to remove gce and just keep build.

https://codereview.chromium.org/2181143002/diff/1/masters/master.tryserver.ch...
masters/master.tryserver.chromium.win/slaves.cfg:112: 'win_optional_chromium',
Please create a unique pool name, e.g. 'win_optional_highend'

[lijeffrey, 2016-07-26 01:17:00]

Comments addressed, mind a quick glance over?

https://codereview.chromium.org/2181143002/diff/1/masters/master.tryserver.ch...
File masters/master.tryserver.chromium.win/slaves.cfg (right):

https://codereview.chromium.org/2181143002/diff/1/masters/master.tryserver.ch...
masters/master.tryserver.chromium.win/slaves.cfg:8: build=False):
On 2016/07/26 00:14:44, Sergey Berezin wrote:
> nit: this may be better served by prefix='vm', and just specifying the correct
> prefix at the call site.
> 
> In fact, gce is not used it this file (we don't have GCE windows bots). So
> another option is to remove gce and just keep build.

Cool. I'll go with the prefix='vm' route in case we add GCE support in the
future

https://codereview.chromium.org/2181143002/diff/1/masters/master.tryserver.ch...
masters/master.tryserver.chromium.win/slaves.cfg:112: 'win_optional_chromium',
On 2016/07/26 00:14:44, Sergey Berezin wrote:
> Please create a unique pool name, e.g. 'win_optional_highend'

Done.

[Sergey Berezin, 2016-07-26 18:25:26]

LGTM, thanks!

[lijeffrey, 2016-07-26 18:49:49]

The CQ bit was checked by lijeffrey@chromium.org

[commit-bot: I haz the power, 2016-07-26 18:49:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 18:53:12]

Description was changed from

==========
Moving Findit variable builder to experimental high-end bot

BUG=631251
==========

to

==========
Moving Findit variable builder to experimental high-end bot

BUG=631251

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/ce4a301430a22466ef81...
==========

[commit-bot: I haz the power, 2016-07-26 18:53:13]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/ce4a301430a22466ef81...