Moving Findit variable builder to experimental high-end bot

masters/master.tryserver.chromium.win/slaves.cfg

 # -*- python -*-
 # ex: set syntax=python:
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-def distribute_slaves(slave_numbers, builders, os_ver, pool=None, gce=False):
-  hostname_format = 'vm%d-m4' if not gce else 'slave%d-c4'
+def distribute_slaves(slave_numbers, builders, os_ver, pool=None, gce=False,
+                      build=False):

[Sergey Berezin, 2016/07/26 00:14:44]

nit: this may be better served by prefix='vm', and just specifying the correct
prefix at the call site.

In fact, gce is not used it this file (we don't have GCE windows bots). So
another option is to remove gce and just keep build.

[lijeffrey, 2016/07/26 01:17:00]

Cool. I'll go with the prefix='vm' route in case we add GCE support in the
future

+  if build:
+    hostname_format = 'build%d-m4'
+  else:
+    hostname_format = 'vm%d-m4' if not gce else 'slave%d-c4'
+
   return [
     {
       'master': 'TryServerChromiumWin',
       'builder': builders,
       'preferred_builder': (builders[i % len(builders)]
                             if slave_numbers >= builders
                             else None),
       'hostname': hostname_format % number,
       'os': 'win',
       'version': os_ver,
@@ skipping 31 matching lines @@
       'win_archive',
       'win_x64_archive',
       # directory: win_upload_clang
       'win_upload_clang',  # Needs to be shorter than 17 chars, crbug.com/600465
   ]
 
   optional_pool_gn = distribute_slaves(
       optional_slaves_gn, optional_builders_gn, 'win7', 'win_optional_gn')
 
   optional_slaves_chromium = [181, 185, 186, 187, 192]
+  optional_high_end_slaves_chromium = [533]
+
   optional_builders_chromium = [
     # directory: win
     'win_chromium_compile_rel_ng',
     'win_chromium_dbg_ng',
     'win_chromium_syzyasan_rel',
     'win_chromium_variable',
     'win_chromium_variable_clang',
     'win_optional_gpu_tests_rel',
     # directory: win_archive
     'win_chromium_variable_archive',
     # directory: win_chrome
     'win_chromium_variable_chrome',
     # directory: win_clang
     'win_chrome_official',
     # directory: win_gn
     'win_chromium_variable_gn',
     # directory: win_layout
     'win_chromium_variable_webkit_layout',
     # directory: win_webkit
     'win_chromium_variable_webkit_builder',
     'win_chromium_variable_webkit_win7_builder',
-    'win_chromium_variable_webkit_win7_builder_x64',
     # directory: win_nacl_sdk
     'win_nacl_sdk',
     # directory: win_nacl_sdk_build
     'win_nacl_sdk_build',
     # directory: win_x64
     'win_x64_chromium_variable_builder',
   ]
+
+  # Experimental optional builders on high-end machines.
+  optional_builders_chromium_2 = [
+    # directory: win_webkit
+    'win_chromium_variable_webkit_win7_builder_x64',
+  ]
+
   optional_pool_chromium = distribute_slaves(
       optional_slaves_chromium,
       optional_builders_chromium,
       'win7',
       'win_optional_chromium')
 
-  optional_pool = optional_pool_chromium + optional_pool_gn
+  optional_high_end_pool_chromium = distribute_slaves(
+      optional_high_end_slaves_chromium,
+      optional_builders_chromium_2,
+      'win7',
+      'win_optional_chromium',

[Sergey Berezin, 2016/07/26 00:14:44]

Please create a unique pool name, e.g. 'win_optional_highend'

[lijeffrey, 2016/07/26 01:17:00]

Done.

+      build=True)
+
+  optional_pool = (optional_pool_chromium + optional_high_end_pool_chromium +
+      optional_pool_gn)
 
   win8_slaves = ([115, 168, 722, 798, 799] + range(384, 399) +
       range(408, 422) + range(468, 495) +
       range(724, 738) + range(801, 804))
   win8_builders = [
       'win8_chromium_gyp_rel',
       'win8_chromium_gyp_dbg',
       'win8_chromium_gn_upload',
       'win10_chromium_x64_rel_ng',
   ]
@@ skipping 41 matching lines @@
   return (
       cq_pool +
       optional_pool +
       win8_pool +
       win_pgo_pool +
       clang_win_pool +
       experimental_pool)
 
 
 slaves = windows()