third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js - Issue 2181123002: DevTools: Remove unused parameters to TextPrompt._loadCompletions callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js

Issue 2181123002: DevTools: Remove unused parameters to TextPrompt._loadCompletions callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove toLowerCase() Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-completions-on-call-frame.html ('k') | third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js b/third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js

index 0573f25821a0397dcc42abb781b457ca9949d3bc..4e3676b025c963e8e50849af1648690e437e396e 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js

@@ -189,13 +189,11 @@ WebInspector.ExecutionContextSelector.prototype = {

/**

* @param {!Element} proxyElement

- * @param {string} text

- * @param {number} cursorOffset

* @param {!Range} wordRange

* @param {boolean} force

* @param {function(!Array.<string>, number=)} completionsReadyCallback

-WebInspector.ExecutionContextSelector.completionsForTextPromptInCurrentContext = function(proxyElement, text, cursorOffset, wordRange, force, completionsReadyCallback)

+WebInspector.ExecutionContextSelector.completionsForTextPromptInCurrentContext = function(proxyElement, wordRange, force, completionsReadyCallback)

{

var executionContext = WebInspector.context.flavor(WebInspector.ExecutionContext);

if (!executionContext) {

@@ -213,5 +211,5 @@ WebInspector.ExecutionContextSelector.completionsForTextPromptInCurrentContext =

expressionString = expressionString.substr(pos + 1);

var prefix = wordRange.toString();

- executionContext.completionsForExpression(expressionString, text, cursorOffset, prefix, force, completionsReadyCallback);

+ executionContext.completionsForExpression(expressionString, prefix, force, completionsReadyCallback);

}