Pass a fake version of Flash that will not be overridden by component,

Pass a fake version of Flash that will not be overridden by component,
system, or bundled implementations of Flash.

Previously, the version defaulted to 10.2.999.999, which will be
overridden by component updates (~22.0.0.209 at this time).

BUG=chromium:623804
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/db2aa902c99c0551f2dfe031aa478f6e9f28efd8

[waffles, 2016-07-25 22:10:42]

waffles@chromium.org changed reviewers:
+ aiolos@chromium.org

[waffles, 2016-07-25 22:10:42]

Hi aiolos, PTAL!

This is expected to fix several perf regressions introduced by
5a2538963cbd28c53ed0f4befc24bd9b4d99f77c.

[waffles, 2016-07-25 22:10:50]

The CQ bit was checked by waffles@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 22:10:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 22:26:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 22:26:23]

Dry run: Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[aiolos (Not reviewing), 2016-07-25 22:44:04]

https://codereview.chromium.org/2181093002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
(right):

https://codereview.chromium.org/2181093002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py:257:
args.append('--ppapi-flash-version=99.9.999.999')
Why is this useful? I assume this would obscure bugs caused by us using the
wrong version of flash.

[waffles, 2016-07-25 23:06:37]

https://codereview.chromium.org/2181093002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
(right):

https://codereview.chromium.org/2181093002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py:257:
args.append('--ppapi-flash-version=99.9.999.999')
On 2016/07/25 22:44:03, aiolos wrote:
> Why is this useful? I assume this would obscure bugs caused by us using the
> wrong version of flash.

That problem already exists: if no flag is specified, the flag value defaults to
10.2.999.999, which is just as incorrect (the current version of Flash is
22.0.0.209 and changes pretty frequently).

Chrome looks up all candidate Flash implementations and picks the
highest-versioned one; so currently it will look and say (for example):

I have bundled flash at ./out/GN/PepperFlash @ 22.0.0.209.
I have component flash at DIR_USER_DATA @ 22.0.0.200.
I have system flash at .../Adobe/PepperFlash @ 22.0.0.199.
I have flag flash at [--ppapi-flash-path] @ 10.2.999.999.

It will then load the greatest-versioned, which will be the bundled flash, not
the --ppapi-flash-path.

In practice passing 99.9.999.999 is harmless, and it's what the only other user
of this flag does:
https://cs.chromium.org/chromium/src/tools/bisect-builds.py?l=544

[waffles, 2016-07-25 23:11:34]

Description was changed from

==========
Pass a fake version of Flash that will not be overridden by component,
system, or bundled implementations of Flash.

Previously, the version defaulted to 10.2.999.999, which will be
overridden by component updates (~22.0.0.209 at this time).

BUG=623804
==========

to

==========
Pass a fake version of Flash that will not be overridden by component,
system, or bundled implementations of Flash.

Previously, the version defaulted to 10.2.999.999, which will be
overridden by component updates (~22.0.0.209 at this time).

BUG=chromium:623804
==========

[waffles, 2016-07-25 23:11:54]

The CQ bit was checked by waffles@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 23:12:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 23:13:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 23:13:11]

Dry run: This issue passed the CQ dry run.

[aiolos (Not reviewing), 2016-07-26 17:23:54]

https://codereview.chromium.org/2181093002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
(right):

https://codereview.chromium.org/2181093002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py:257:
args.append('--ppapi-flash-version=99.9.999.999')
On 2016/07/25 23:06:36, waffles wrote:
> On 2016/07/25 22:44:03, aiolos wrote:
> > Why is this useful? I assume this would obscure bugs caused by us using the
> > wrong version of flash.
> 
> That problem already exists: if no flag is specified, the flag value defaults
to
> 10.2.999.999, which is just as incorrect (the current version of Flash is
> 22.0.0.209 and changes pretty frequently).
> 
> Chrome looks up all candidate Flash implementations and picks the
> highest-versioned one; so currently it will look and say (for example):
> 
> I have bundled flash at ./out/GN/PepperFlash @ 22.0.0.209.
> I have component flash at DIR_USER_DATA @ 22.0.0.200.
> I have system flash at .../Adobe/PepperFlash @ 22.0.0.199.
> I have flag flash at [--ppapi-flash-path] @ 10.2.999.999.
> 
> It will then load the greatest-versioned, which will be the bundled flash, not
> the --ppapi-flash-path.
> 
> In practice passing 99.9.999.999 is harmless, and it's what the only other
user
> of this flag does:
> https://cs.chromium.org/chromium/src/tools/bisect-builds.py?l=544

lgtm, but please add a comment noting why we're passing that version in.

[waffles, 2016-07-26 17:27:36]

https://codereview.chromium.org/2181093002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
(right):

https://codereview.chromium.org/2181093002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py:257:
args.append('--ppapi-flash-version=99.9.999.999')
On 2016/07/26 17:23:54, aiolos wrote:
> On 2016/07/25 23:06:36, waffles wrote:
> > On 2016/07/25 22:44:03, aiolos wrote:
> > > Why is this useful? I assume this would obscure bugs caused by us using
the
> > > wrong version of flash.
> > 
> > That problem already exists: if no flag is specified, the flag value
defaults
> to
> > 10.2.999.999, which is just as incorrect (the current version of Flash is
> > 22.0.0.209 and changes pretty frequently).
> > 
> > Chrome looks up all candidate Flash implementations and picks the
> > highest-versioned one; so currently it will look and say (for example):
> > 
> > I have bundled flash at ./out/GN/PepperFlash @ 22.0.0.209.
> > I have component flash at DIR_USER_DATA @ 22.0.0.200.
> > I have system flash at .../Adobe/PepperFlash @ 22.0.0.199.
> > I have flag flash at [--ppapi-flash-path] @ 10.2.999.999.
> > 
> > It will then load the greatest-versioned, which will be the bundled flash,
not
> > the --ppapi-flash-path.
> > 
> > In practice passing 99.9.999.999 is harmless, and it's what the only other
> user
> > of this flag does:
> > https://cs.chromium.org/chromium/src/tools/bisect-builds.py?l=544
> 
> lgtm, but please add a comment noting why we're passing that version in.

Done, thanks!

[waffles, 2016-07-26 17:27:39]

The CQ bit was checked by waffles@chromium.org

[waffles, 2016-07-26 17:27:40]

The patchset sent to the CQ was uploaded after l-g-t-m from aiolos@chromium.org
Link to the patchset: https://codereview.chromium.org/2181093002/#ps20001
(title: "Add comment.")

[commit-bot: I haz the power, 2016-07-26 17:27:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 17:54:26]

Description was changed from

==========
Pass a fake version of Flash that will not be overridden by component,
system, or bundled implementations of Flash.

Previously, the version defaulted to 10.2.999.999, which will be
overridden by component updates (~22.0.0.209 at this time).

BUG=chromium:623804
==========

to

==========
Pass a fake version of Flash that will not be overridden by component,
system, or bundled implementations of Flash.

Previously, the version defaulted to 10.2.999.999, which will be
overridden by component updates (~22.0.0.209 at this time).

BUG=chromium:623804

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-07-26 17:54:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...