telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py - Issue 2181093002: Pass a fake version of Flash that will not be overridden by component,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py

Issue 2181093002: Pass a fake version of Flash that will not be overridden by component, (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: Add comment. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py

diff --git a/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py b/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py

index c7fc67a20a4d268229726c8fa0a2f66442adf6ac..43b73cb91eafd098cf0bdd3c64e737d9fa3c7ffc 100644

--- a/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py

+++ b/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py

@@ -254,6 +254,9 @@ class DesktopBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

args.append('--window-size=1280,1024')

if self._flash_path:

args.append('--ppapi-flash-path=%s' % self._flash_path)

+ # Also specify the version of Flash as a large version, so that it is

+ # not overridden by the bundled or component-updated version of Flash.

+ args.append('--ppapi-flash-version=99.9.999.999')

if not self.browser_options.dont_override_profile:

args.append('--user-data-dir=%s' % self._tmp_profile_dir)

else:

« no previous file with comments | « no previous file | no next file » | no next file with comments »