base/android/java/src/org/chromium/base/ThreadUtils.java - Issue 2181053002: android: dcheck_always_on sets BuildConfig.IS_DCHECK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/java/src/org/chromium/base/ThreadUtils.java

Issue 2181053002: android: dcheck_always_on sets BuildConfig.IS_DCHECK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix findbugs Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/java/src/org/chromium/base/BaseChromiumApplication.java ('k') | base/android/java/templates/BuildConfig.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/android/java/src/org/chromium/base/ThreadUtils.java

diff --git a/base/android/java/src/org/chromium/base/ThreadUtils.java b/base/android/java/src/org/chromium/base/ThreadUtils.java

index 5fc1d21324abc6155488a31736d1739faf5e17b8..97e019b335d1882b5ce541e5f165642798008716 100644

--- a/base/android/java/src/org/chromium/base/ThreadUtils.java

+++ b/base/android/java/src/org/chromium/base/ThreadUtils.java

@@ -189,7 +189,7 @@ public class ThreadUtils {

* Asserts that the current thread is running on the main thread.

public static void assertOnUiThread() {

- if (BuildConfig.IS_DEBUG && !runningOnUiThread()) {

+ if (BuildConfig.DCHECK_IS_ON && !runningOnUiThread()) {

throw new IllegalStateException("Must be called on the Ui thread.");

}