Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2881)

Unified Diff: base/android/java/src/org/chromium/base/BaseChromiumApplication.java

Issue 2181053002: android: dcheck_always_on sets BuildConfig.IS_DCHECK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix findbugs Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/BUILD.gn ('k') | base/android/java/src/org/chromium/base/ThreadUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/java/src/org/chromium/base/BaseChromiumApplication.java
diff --git a/base/android/java/src/org/chromium/base/BaseChromiumApplication.java b/base/android/java/src/org/chromium/base/BaseChromiumApplication.java
index 44c69dce6f06b6c35ec1d7dcb52303708c655755..353b798f9ec6806e841d7b0120c9ea86853c759f 100644
--- a/base/android/java/src/org/chromium/base/BaseChromiumApplication.java
+++ b/base/android/java/src/org/chromium/base/BaseChromiumApplication.java
@@ -158,7 +158,7 @@ public class BaseChromiumApplication extends Application {
@Override
public void onActivityDestroyed(Activity activity) {
- if (BuildConfig.IS_DEBUG) {
+ if (BuildConfig.DCHECK_IS_ON) {
assert (Proxy.isProxyClass(activity.getWindow().getCallback().getClass())
|| activity.getWindow().getCallback().getClass().getName().equals(
TOOLBAR_CALLBACK_WRAPPER_CLASS)
@@ -169,7 +169,7 @@ public class BaseChromiumApplication extends Application {
@Override
public void onActivityPaused(Activity activity) {
- if (BuildConfig.IS_DEBUG) {
+ if (BuildConfig.DCHECK_IS_ON) {
assert (Proxy.isProxyClass(activity.getWindow().getCallback().getClass())
|| activity.getWindow().getCallback().getClass().getName().equals(
TOOLBAR_CALLBACK_WRAPPER_CLASS)
@@ -180,7 +180,7 @@ public class BaseChromiumApplication extends Application {
@Override
public void onActivityResumed(Activity activity) {
- if (BuildConfig.IS_DEBUG) {
+ if (BuildConfig.DCHECK_IS_ON) {
assert (Proxy.isProxyClass(activity.getWindow().getCallback().getClass())
|| activity.getWindow().getCallback().getClass().getName().equals(
TOOLBAR_CALLBACK_WRAPPER_CLASS)
@@ -191,7 +191,7 @@ public class BaseChromiumApplication extends Application {
@Override
public void onActivitySaveInstanceState(Activity activity, Bundle outState) {
- if (BuildConfig.IS_DEBUG) {
+ if (BuildConfig.DCHECK_IS_ON) {
assert (Proxy.isProxyClass(activity.getWindow().getCallback().getClass())
|| activity.getWindow().getCallback().getClass().getName().equals(
TOOLBAR_CALLBACK_WRAPPER_CLASS)
@@ -202,7 +202,7 @@ public class BaseChromiumApplication extends Application {
@Override
public void onActivityStarted(Activity activity) {
- if (BuildConfig.IS_DEBUG) {
+ if (BuildConfig.DCHECK_IS_ON) {
assert (Proxy.isProxyClass(activity.getWindow().getCallback().getClass())
|| activity.getWindow().getCallback().getClass().getName().equals(
TOOLBAR_CALLBACK_WRAPPER_CLASS)
@@ -213,7 +213,7 @@ public class BaseChromiumApplication extends Application {
@Override
public void onActivityStopped(Activity activity) {
- if (BuildConfig.IS_DEBUG) {
+ if (BuildConfig.DCHECK_IS_ON) {
assert (Proxy.isProxyClass(activity.getWindow().getCallback().getClass())
|| activity.getWindow().getCallback().getClass().getName().equals(
TOOLBAR_CALLBACK_WRAPPER_CLASS)
« no previous file with comments | « base/BUILD.gn ('k') | base/android/java/src/org/chromium/base/ThreadUtils.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698