Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: chrome/BUILD.gn

Issue 2181043003: Fix GN build on mac with icu_use_data_file = false (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/shell/BUILD.gn » ('j') | content/shell/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index ee1ff08716937489da3b345289c23bbecd25ab1d..5de11972346fd304265b161363a75394bacf94c7 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -28,6 +28,7 @@ if (is_android) {
import("//build/util/version.gni")
import("//build_overrides/v8.gni")
import("//media/cdm/ppapi/cdm_paths.gni")
+ import("//third_party/icu/config.gni")
}
if (is_win) {
@@ -721,10 +722,12 @@ if (is_win) {
"$root_gen_dir/repack/resources.pak",
"$root_out_dir/app_mode_loader.app",
"$root_out_dir/chrome_100_percent.pak",
- "$root_out_dir/icudtl.dat",
"app/theme/default_100_percent/$branding_path_component/product_logo_32.png",
"browser/mac/install.sh",
]
+ if (icu_use_data_file) {
+ sources += [ "$root_out_dir/icudtl.dat" ]
+ }
outputs = [
"{{bundle_resources_dir}}/{{source_file_part}}",
« no previous file with comments | « no previous file | content/shell/BUILD.gn » ('j') | content/shell/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698