Fix GN build on mac with icu_use_data_file = false

chrome/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/buildflag_header.gni")
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/features.gni")
 import("//build/config/locales.gni")
 import("//build/config/sanitizers/sanitizers.gni")
@@ skipping 10 matching lines @@
   import("//build/config/android/rules.gni")
 } else if (is_mac) {
   import("//build/compiled_action.gni")
   import("//build/config/mac/rules.gni")
   import("//build/config/mac/symbols.gni")
   import("//build/mac/tweak_info_plist.gni")
   import("//build/util/branding.gni")
   import("//build/util/version.gni")
   import("//build_overrides/v8.gni")
   import("//media/cdm/ppapi/cdm_paths.gni")
+  import("//third_party/icu/config.gni")
 }
 
 if (is_win) {
   action("reorder_imports") {
     script = "//build/win/reorder-imports.py"
 
     # See comment in chrome_dll.gypi in the hardlink_to_output
     # target for why this cannot be 'initial' like the DLL.
     inputs = [
       "$root_out_dir/initialexe/chrome.exe",
@@ skipping 673 matching lines @@
       # This image is used to badge the lock icon in the
       # authentication dialogs, such as those used for installation
       # from disk image and Keystone promotion (if so enabled).  It
       # needs to exist as a file on disk and not just something in a
       # resource bundle because that's the interface that
       # Authorization Services uses.  Also, Authorization Services
       # can't deal with .icns files.
       "$root_gen_dir/repack/resources.pak",
       "$root_out_dir/app_mode_loader.app",
       "$root_out_dir/chrome_100_percent.pak",
-      "$root_out_dir/icudtl.dat",
       "app/theme/default_100_percent/$branding_path_component/product_logo_32.png",
       "browser/mac/install.sh",
     ]
+    if (icu_use_data_file) {
+      sources += [ "$root_out_dir/icudtl.dat" ]
+    }
 
     outputs = [
       "{{bundle_resources_dir}}/{{source_file_part}}",
     ]
 
     public_deps = [
       ":packed_extra_resources",
       ":packed_resources",
       "//chrome/app_shim:app_mode_loader",
       "//third_party/icu:icudata",
@@ skipping 12 matching lines @@
         sources += [ "$root_out_dir/chrome_material_200_percent.pak" ]
       }
     }
 
     if (enable_mac_keystone) {
       sources += [
         "browser/mac/keystone_promote_postflight.sh",
         "browser/mac/keystone_promote_preflight.sh",
       ]
     }
 

[Robert Sesek, 2016/07/25 22:33:44]

I'd move the sources += down here and then also remove line 740 and make it
conditionally add public_deps += [ "//third_party/icu:icudata" ].

[jungshik at Google, 2016/07/26 00:15:18]

Thanks. Done

     if (v8_use_external_startup_data) {
       sources += [
         "$root_out_dir/natives_blob.bin",
         "$root_out_dir/snapshot_blob.bin",
       ]
       public_deps += [ "//v8" ]
     }
   }
 
   # When debug_devtools is enabled, symlink the inspector resources into the
@@ skipping 1041 matching lines @@
       "//chrome/app/theme/$branding_path_component/product_logo_48.png",
       "//chrome/tools/build/linux/chrome-wrapper",
       "//third_party/xdg-utils/scripts/xdg-mime",
       "//third_party/xdg-utils/scripts/xdg-settings",
     ]
     outputs = [
       "$root_out_dir/{{source_file_part}}",
     ]
   }
 }