Issue 2180963002: [Material][Mac] Fixed Bookmark Items Highlight Issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2180963002: [Material][Mac] Fixed Bookmark Items Highlight Issues (Closed)

Created:
4 years, 5 months ago by spqchan

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews, tfarina, noyau+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

[Material][Mac] Fixed Bookmark Items Highlight Issues Remove calls to setHighlighted: for MD bookmark items. Ensure that the items aren't highlighted when they are not enabled BUG=627722, 628187, 628204 Review-Url: https://codereview.chromium.org/2169623002 Cr-Commit-Position: refs/heads/master@{#407032} (cherry picked from commit 1078d2565c0bc53dd9ef982d246fd9ac3dd49309) Committed: https://chromium.googlesource.com/chromium/src/+/44233fd40b47ebf61fdef0f922f8b910f0e18b11

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -4 lines)			Patch
M	chrome/browser/ui/cocoa/download/download_item_controller.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_item_controller.mm	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_shelf_controller.mm	View	1	3 chunks	+11 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

spqchan

4 years, 4 months ago (2016-08-01 16:59:42 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
44233fd40b47ebf61fdef0f922f8b910f0e18b11.