Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5201)

Unified Diff: chrome/test/data/webui/settings/privacy_page_test.js

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/privacy_page_test.js
diff --git a/chrome/test/data/webui/settings/privacy_page_test.js b/chrome/test/data/webui/settings/privacy_page_test.js
index 7109cfafaab74ea999b66cc77392cfe9d2ee7b68..9408b166eb77d3f60187c3dc003825a03d34dfaf 100644
--- a/chrome/test/data/webui/settings/privacy_page_test.js
+++ b/chrome/test/data/webui/settings/privacy_page_test.js
@@ -113,7 +113,7 @@ cr.define('settings_privacy_page', function() {
teardown(function() { element.remove(); });
test('ClearBrowsingDataTap', function() {
- assertTrue(element.$.dialog.opened);
+ assertTrue(element.$.dialog.open);
var cancelButton = element.$$('.cancel-button');
assertTrue(!!cancelButton);
@@ -132,7 +132,7 @@ cr.define('settings_privacy_page', function() {
return testBrowserProxy.whenCalled('clearBrowsingData').then(
function() {
- assertTrue(element.$.dialog.opened);
+ assertTrue(element.$.dialog.open);
assertTrue(cancelButton.disabled);
assertTrue(actionButton.disabled);
assertTrue(spinner.active);
@@ -145,7 +145,7 @@ cr.define('settings_privacy_page', function() {
// Promise that was just resolved to execute before the
// assertions.
}).then(function() {
- assertFalse(element.$.dialog.opened);
+ assertFalse(element.$.dialog.open);
assertFalse(cancelButton.disabled);
assertFalse(actionButton.disabled);
assertFalse(spinner.active);
@@ -154,7 +154,7 @@ cr.define('settings_privacy_page', function() {
});
test('showHistoryDeletionDialog', function() {
- assertTrue(element.$.dialog.opened);
+ assertTrue(element.$.dialog.open);
var actionButton = element.$$('.action-button');
assertTrue(!!actionButton);
@@ -178,8 +178,8 @@ cr.define('settings_privacy_page', function() {
var noticeActionButton = notice.$$('.action-button');
assertTrue(!!noticeActionButton);
- assertTrue(element.$.dialog.opened);
- assertTrue(notice.$.dialog.opened);
+ assertTrue(element.$.dialog.open);
+ assertTrue(notice.$.dialog.open);
MockInteractions.tap(noticeActionButton);
@@ -190,13 +190,13 @@ cr.define('settings_privacy_page', function() {
setTimeout(function() {
var notice = element.$$('#notice');
assertFalse(!!notice);
- assertFalse(element.$.dialog.opened);
+ assertFalse(element.$.dialog.open);
}, 0);
});
});
test('Counters', function() {
- assertTrue(element.$.dialog.opened);
+ assertTrue(element.$.dialog.open);
// Initialize the browsing history pref, which should belong to the
// first checkbox in the dialog.

Powered by Google App Engine
This is Rietveld 408576698