chrome/test/data/webui/settings/people_page_test.js - Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/settings/people_page_test.js

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/webui/settings/certificate_manager_page_test.js ('K') | « chrome/test/data/webui/settings/fake_bluetooth.js ('k') | chrome/test/data/webui/settings/privacy_page_test.js » ('j') | ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/settings/people_page_test.js

diff --git a/chrome/test/data/webui/settings/people_page_test.js b/chrome/test/data/webui/settings/people_page_test.js

index e7088d6e05210c2e9db9f0341311b37546e33ecc..916d7bb2c292f406eba972ab4e0d4c4490e7b8b3 100644

--- a/chrome/test/data/webui/settings/people_page_test.js

+++ b/chrome/test/data/webui/settings/people_page_test.js

@@ -158,7 +158,7 @@ cr.define('settings_people_page', function() {

MockInteractions.tap(disconnectButton);

Polymer.dom.flush();

- assertTrue(peoplePage.$.disconnectDialog.opened);

+ assertTrue(peoplePage.$.disconnectDialog.open);

assertFalse(peoplePage.$.deleteProfile.hidden);

var disconnectConfirm = peoplePage.$.disconnectConfirm;

@@ -178,11 +178,11 @@ cr.define('settings_people_page', function() {

});

Polymer.dom.flush();

- assertFalse(peoplePage.$.disconnectDialog.opened);

+ assertFalse(peoplePage.$.disconnectDialog.open);

MockInteractions.tap(disconnectButton);

Polymer.dom.flush();

- assertTrue(peoplePage.$.disconnectDialog.opened);

+ assertTrue(peoplePage.$.disconnectDialog.open);

assertTrue(peoplePage.$.deleteProfile.hidden);

var disconnectManagedProfileConfirm =