chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js - Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/webui/md_history/history_list_test.js ('k') | chrome/test/data/webui/settings/certificate_manager_page_test.js » ('j') | chrome/test/data/webui/settings/certificate_manager_page_test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js

diff --git a/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js b/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js

index 663e092018ffc85e7bc1d1b4b60d664f420af1e9..3cb27a0a324f3ed72c1b717bfd96ee6c4ec1a9ac 100644

--- a/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js

+++ b/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js

@@ -162,7 +162,7 @@ TEST_F('SettingsBluetoothPageBrowserTest', 'MAYBE_Bluetooth', function() {

// Ensure the dialog appears.

var dialog = bluetooth.$.deviceDialog;

assertTrue(!!dialog);

- assertTrue(dialog.$.dialog.opened);

+ assertTrue(dialog.$.dialog.open);

// Ensure the dialog has the expected devices.

var devicesDiv = dialog.$$('#dialogDeviceList');

@@ -185,7 +185,7 @@ TEST_F('SettingsBluetoothPageBrowserTest', 'MAYBE_Bluetooth', function() {

assertTrue(!!close);

MockInteractions.tap(close);

Polymer.dom.flush();

- expectFalse(dialog.$.dialog.opened);

+ expectFalse(dialog.$.dialog.open);

var response = self.bluetoothPrivateApi_.pairingResponses_[deviceAddress];

assertTrue(!!response);

expectEquals(chrome.bluetoothPrivate.PairingResponse.CANCEL,