chrome/test/data/webui/md_history/history_list_test.js - Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/md_history/history_list_test.js

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_list.js ('k') | chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js » ('j') | chrome/test/data/webui/settings/certificate_manager_page_test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/md_history/history_list_test.js

diff --git a/chrome/test/data/webui/md_history/history_list_test.js b/chrome/test/data/webui/md_history/history_list_test.js

index e8fa1c7626702ace264ac7223175bda2bfc642b2..f54c605f1a00aeb3628fbd09b6c57c54f5bc685c 100644

--- a/chrome/test/data/webui/md_history/history_list_test.js

+++ b/chrome/test/data/webui/md_history/history_list_test.js

@@ -234,7 +234,7 @@ cr.define('md_history.history_list_test', function() {

'2016-03-13');

assertEquals(element.historyData_[4].dateRelativeDay,

'2016-03-11');

- assertFalse(listContainer.$.dialog.opened);

+ assertFalse(listContainer.$.dialog.open);

done();

});

@@ -242,7 +242,7 @@ cr.define('md_history.history_list_test', function() {

MockInteractions.tap(app.$.toolbar.$$('#delete-button'));

// Confirmation dialog should appear.

- assertTrue(listContainer.$.dialog.opened);

+ assertTrue(listContainer.$.dialog.open);

MockInteractions.tap(listContainer.$$('.action-button'));

});

@@ -257,7 +257,7 @@ cr.define('md_history.history_list_test', function() {

// Dialog should not appear when there is no item selected.

MockInteractions.pressAndReleaseKeyOn(

document.body, 46, '', 'Delete');

- assertFalse(listContainer.$.dialog.opened);

+ assertFalse(listContainer.$.dialog.open);

MockInteractions.tap(items[1].$.checkbox);

MockInteractions.tap(items[2].$.checkbox);

@@ -274,14 +274,14 @@ cr.define('md_history.history_list_test', function() {

MockInteractions.pressAndReleaseKeyOn(

document.body, 46, '', 'Delete');

- assertTrue(listContainer.$.dialog.opened);

+ assertTrue(listContainer.$.dialog.open);

MockInteractions.tap(listContainer.$$('.cancel-button'));

- assertFalse(listContainer.$.dialog.opened);

+ assertFalse(listContainer.$.dialog.open);

MockInteractions.pressAndReleaseKeyOn(

document.body, 8, '', 'Backspace');

- assertTrue(listContainer.$.dialog.opened);

+ assertTrue(listContainer.$.dialog.open);

MockInteractions.tap(listContainer.$$('.action-button'));

});