chrome/test/data/webui/settings/startup_urls_page_test.js - Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/settings/startup_urls_page_test.js

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html ('K') | « chrome/test/data/webui/settings/settings_autofill_section_browsertest.js ('k') | ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html » ('j') | ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/settings/startup_urls_page_test.js

diff --git a/chrome/test/data/webui/settings/startup_urls_page_test.js b/chrome/test/data/webui/settings/startup_urls_page_test.js

index 53489dc68ef360a61157b52d1e856a449a5e3125..f8dd9cda179471f5dd3ba86c39a8d7e805323c31 100644

--- a/chrome/test/data/webui/settings/startup_urls_page_test.js

+++ b/chrome/test/data/webui/settings/startup_urls_page_test.js

@@ -91,7 +91,7 @@ cr.define('settings_startup_urls_page', function() {

test('Initialization_Add', function() {

document.body.appendChild(dialog);

- assertTrue(dialog.$.dialog.opened);

+ assertTrue(dialog.$.dialog.open);

// Assert that the "Add" button is disabled.

var actionButton = dialog.$.actionButton;

@@ -107,7 +107,7 @@ cr.define('settings_startup_urls_page', function() {

test('Initialization_Edit', function() {

dialog.model = createSampleUrlEntry();

document.body.appendChild(dialog);

- assertTrue(dialog.$.dialog.opened);

+ assertTrue(dialog.$.dialog.open);

// Assert that the "Edit" button is enabled.

var actionButton = dialog.$.actionButton;

@@ -161,7 +161,7 @@ cr.define('settings_startup_urls_page', function() {

browserProxy.setUrlValidity(false);

MockInteractions.tap(actionButton);

return browserProxy.whenCalled(proxyMethodName).then(function() {

- assertTrue(dialog.$.dialog.opened);

+ assertTrue(dialog.$.dialog.open);

// Test that dialog is closed if the user submits a valid URL.

browserProxy.setUrlValidity(true);

@@ -169,7 +169,7 @@ cr.define('settings_startup_urls_page', function() {

MockInteractions.tap(actionButton);

return browserProxy.whenCalled(proxyMethodName);

}).then(function() {

- assertFalse(dialog.$.dialog.opened);

+ assertFalse(dialog.$.dialog.open);

});

}