Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
index b471c22d415e4c77058627b2533f04a74894126d..97b3e81db977a641577c40bb603d9f6de0fc3afd 100644
--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
@@ -107,7 +107,7 @@
<!-- #notice correctly places its own backdrop above #dialog and under
itself, so when it is shown, #dialog should not use backdrop. -->
- <cr-dialog id="dialog" with-backdrop="[[!showHistoryDeletionDialog_]]">
+ <dialog is="cr-dialog" id="dialog" with-backdrop="[[!showHistoryDeletionDialog_]]">
Dan Beam 2016/07/26 23:36:12 nit: 80 col wrap
dpapad 2016/07/27 01:21:47 Ah, I am realizing that |with-backdrop| is somethi
<div class="title">$i18n{clearBrowsingData}</div>
<div class="body">
<div class="row">
@@ -163,7 +163,7 @@
<div class="button-container">
<paper-spinner active="[[clearingInProgress_]]"></paper-spinner>
<paper-button class="cancel-button" disabled="[[clearingInProgress_]]"
- dialog-dismiss>$i18n{cancel}</paper-button>
Dan Beam 2016/07/26 23:36:12 are you sure you got all of these? what about dial
dpapad 2016/07/27 01:21:47 I had missed a dialog-confirm occurrence in site_s
+ on-tap="onCancelTap_">$i18n{cancel}</paper-button>
<paper-button class="action-button" disabled="[[clearingInProgress_]]"
on-tap="onClearBrowsingDataTap_">
$i18n{clearBrowsingData}
@@ -185,7 +185,7 @@
</div>
</div>
</div>
- </cr-dialog>
+ </dialog>
<template is="dom-if" if="[[showHistoryDeletionDialog_]]" restamp>
<settings-history-deletion-dialog id="notice"

Powered by Google App Engine
This is Rietveld 408576698