chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js - Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html ('K') | « chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html ('k') | chrome/browser/resources/settings/search_engines_page/search_engine_entry.js » ('j') | ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js b/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

index eb272e5df80e5f15cd771d12fdc83c2523c91504..7f36e61e898c67708316f69c42b891636ee340be 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

@@ -66,7 +66,7 @@ Polymer({

this.actionButtonText_ = loadTimeData.getString('add');

}

- this.addEventListener('iron-overlay-canceled', function() {

+ this.addEventListener('cancel', function() {

this.browserProxy_.searchEngineEditCancelled();

}.bind(this));

@@ -76,7 +76,7 @@ Polymer({

this.updateActionButtonState_();

this.browserProxy_.searchEngineEditStarted(

this.model ? this.model.modelIndex : this.DEFAULT_MODEL_INDEX);

- this.$.dialog.open();

+ this.$.dialog.showModal();

/** @private */