Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2354)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.js

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page.js
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.js b/chrome/browser/resources/settings/privacy_page/privacy_page.js
index afdd7b4a2c66209cbf987691dffaf01574ae09d4..cebcccf9ef21ed909edd9e4dce7c233ab9094c81 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.js
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.js
@@ -38,17 +38,6 @@ Polymer({
this.ContentSettingsTypes = settings.ContentSettingsTypes;
},
- /** @suppress {missingProperties} */
- attached: function() {
- settings.main.rendered.then(function() {
- if (this.showClearBrowsingDataDialog_) {
- var dialog = this.$$('settings-clear-browsing-data-dialog').$.dialog;
- // TODO(dbeam): cast to a CrDialogElement when it compiles.
- dialog.refit();
- }
- }.bind(this));
- },
-
/**
* @return {boolean} Whether the Clear Browsing Data dialog should be showing.
* @private
@@ -90,10 +79,7 @@ Polymer({
* @param {!Event} event
* @private
*/
- onIronOverlayClosed_: function(event) {
- if (Polymer.dom(event).rootTarget.tagName != 'CR-DIALOG')
- return;
-
+ onDialogClosed_: function(event) {
this.currentRoute = {
page: 'advanced',
section: 'privacy',

Powered by Google App Engine
This is Rietveld 408576698