chrome/browser/resources/settings/device_page/display_overscan_dialog.js - Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/device_page/display_overscan_dialog.js

Issue 2180823004: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html ('K') | « chrome/browser/resources/settings/device_page/display_overscan_dialog.html ('k') | chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html » ('j') | ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/device_page/display_overscan_dialog.js

diff --git a/chrome/browser/resources/settings/device_page/display_overscan_dialog.js b/chrome/browser/resources/settings/device_page/display_overscan_dialog.js

index 14085758ab9025c983a1b06053adb77d12571613..4cb019fcabdedb1d74e988030345aaf1032ed325 100644

--- a/chrome/browser/resources/settings/device_page/display_overscan_dialog.js

+++ b/chrome/browser/resources/settings/device_page/display_overscan_dialog.js

@@ -43,12 +43,14 @@ Polymer({

open: function() {

this.comitted_ = false;

- this.$.dialog.open();

+ this.$.dialog.showModal();

close: function() {

this.displayId = ''; // Will trigger displayIdChanged_.

- this.$.dialog.close();

+ if (this.$.dialog.open)

+ this.$.dialog.close();

/** @private */