Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2180793002: remove fClipStack and attach/deattach-from-canvas (Closed)

Created:
4 years, 5 months ago by reed1
Modified:
4 years, 5 months ago
Reviewers:
hal.canary, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove fClipStack and attach/deattach-from-canvas BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2180793002 Committed: https://skia.googlesource.com/skia/+/2c9e20055be772feb3f44986c1af0c0a979eff49

Patch Set 1 #

Patch Set 2 : no need for attachToCanvas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -100 lines) Patch
M include/core/SkBitmapDevice.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkDevice.h View 1 2 chunks +0 lines, -30 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 3 chunks +6 lines, -12 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 chunks +2 lines, -9 lines 0 comments Download
M src/core/SkDevice.cpp View 1 1 chunk +1 line, -6 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -19 lines 0 comments Download
M src/pdf/SkPDFDevice.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
reed1
4 years, 5 months ago (2016-07-24 21:35:27 UTC) #5
hal.canary
All skp and gm PDFs are byte-identical after this change. SkPDF: LGTM
4 years, 5 months ago (2016-07-25 13:09:47 UTC) #13
bsalomon
lgtm
4 years, 5 months ago (2016-07-25 13:51:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180793002/20001
4 years, 5 months ago (2016-07-25 15:04:27 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 15:05:27 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2c9e20055be772feb3f44986c1af0c0a979eff49

Powered by Google App Engine
This is Rietveld 408576698