Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: include/core/SkDevice.h

Issue 2180793002: remove fClipStack and attach/deattach-from-canvas (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: no need for attachToCanvas Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/core/SkBitmapDevice.h ('k') | src/core/SkBitmapDevice.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkDevice.h
diff --git a/include/core/SkDevice.h b/include/core/SkDevice.h
index 4a2d656e978a735fd27121291d26b184da668425..f3b484e4be227b8b823351e8f0210c33b58aef7c 100644
--- a/include/core/SkDevice.h
+++ b/include/core/SkDevice.h
@@ -112,32 +112,6 @@ public:
*/
const SkIPoint& getOrigin() const { return fOrigin; }
- /**
- * onAttachToCanvas is invoked whenever a device is installed in a canvas
- * (i.e., setDevice, saveLayer (for the new device created by the save),
- * and SkCanvas' SkBaseDevice & SkBitmap -taking ctors). It allows the
- * devices to prepare for drawing (e.g., locking their pixels, etc.)
- */
- virtual void onAttachToCanvas(SkCanvas*) {
- SkASSERT(!fAttachedToCanvas);
-#ifdef SK_DEBUG
- fAttachedToCanvas = true;
-#endif
- };
-
- /**
- * onDetachFromCanvas notifies a device that it will no longer be drawn to.
- * It gives the device a chance to clean up (e.g., unlock its pixels). It
- * is invoked from setDevice (for the displaced device), restore and
- * possibly from SkCanvas' dtor.
- */
- virtual void onDetachFromCanvas() {
- SkASSERT(fAttachedToCanvas);
-#ifdef SK_DEBUG
- fAttachedToCanvas = false;
-#endif
- };
-
protected:
enum TileUsage {
kPossible_TileUsage, //!< the created device may be drawn tiled
@@ -398,10 +372,6 @@ private:
SkBitmap fLegacyBitmap;
#endif
-#ifdef SK_DEBUG
- bool fAttachedToCanvas;
-#endif
-
typedef SkRefCnt INHERITED;
};
« no previous file with comments | « include/core/SkBitmapDevice.h ('k') | src/core/SkBitmapDevice.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698