Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: components/password_manager/core/browser/login_database_unittest.cc

Issue 2180773002: Disable broken iOS10 password manager tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simulator only Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/login_database_ios_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/login_database_unittest.cc
diff --git a/components/password_manager/core/browser/login_database_unittest.cc b/components/password_manager/core/browser/login_database_unittest.cc
index bb2ea4d67b736a90680918997164a3def66082c1..bbbb3a1842033336de5e1b7e96f46b8c2e300952 100644
--- a/components/password_manager/core/browser/login_database_unittest.cc
+++ b/components/password_manager/core/browser/login_database_unittest.cc
@@ -12,6 +12,7 @@
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
+#include "base/ios/ios_util.h"
rohitrao (ping after 24h) 2016/07/24 23:04:55 This is a cross-platform test, so this include wil
justincohen 2016/07/25 15:11:52 Done.
#include "base/memory/scoped_vector.h"
#include "base/path_service.h"
#include "base/strings/string_number_conversions.h"
@@ -210,6 +211,12 @@ class LoginDatabaseTest : public testing::Test {
};
TEST_F(LoginDatabaseTest, Logins) {
+#if TARGET_IPHONE_SIMULATOR
+ // TODO(crbug.com/619982): Broken by iOS10.
rohitrao (ping after 24h) 2016/07/24 23:04:55 I would be more specific in this comment and say t
justincohen 2016/07/25 15:11:52 Done.
+ if (base::ios::IsRunningOnIOS10OrLater()) {
+ return;
+ }
+#endif
ScopedVector<autofill::PasswordForm> result;
// Verify the database is empty.
« no previous file with comments | « components/password_manager/core/browser/login_database_ios_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698