vm-service: Include pauseEvent even when running without debugger support.

vm-service: Include pauseEvent even when running without debugger support.

Pausing the isolate at event boundries, such as --pause-isolates-on-start, doesn't require debugger support.

Fix crash in getStack RPC when running the JIT with --support-debugger=false.

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/2c7983a1d19cfad9ec335d0d5db07e569ba90346

[rmacnak, 2016-07-22 23:07:48]

rmacnak@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-07-25 13:53:21]

lgtm

https://codereview.chromium.org/2180613002/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2180613002/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:1947: } else if (debugger() != NULL &&
(debugger() != NULL) &&
(debugger()->PauseEvent() != NULL) &&
...

[rmacnak, 2016-07-25 16:24:34]

Description was changed from

==========
vm-service: Include pauseEvent even when running without debugger support.

Pausing the isolate at event boundries, such as --pause-isolates-on-start,
doesn't require debugger support.

Fix crash in getStack RPC when running the JIT with --support-debugger=false.
==========

to

==========
vm-service: Include pauseEvent even when running without debugger support.

Pausing the isolate at event boundries, such as --pause-isolates-on-start,
doesn't require debugger support.

Fix crash in getStack RPC when running the JIT with --support-debugger=false.

R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2c7983a1d19cfad9ec335d0d5db07e569ba90346
==========

[rmacnak, 2016-07-25 16:24:36]

Committed patchset #2 (id:20001) manually as
2c7983a1d19cfad9ec335d0d5db07e569ba90346 (presubmit successful).

[rmacnak, 2016-07-25 16:24:40]

https://codereview.chromium.org/2180613002/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2180613002/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:1947: } else if (debugger() != NULL &&
On 2016/07/25 13:53:21, Cutch wrote:
> (debugger() != NULL) &&
> (debugger()->PauseEvent() != NULL) &&
> ...

Done.