Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: runtime/vm/service.cc

Issue 2180613002: vm-service: Include pauseEvent even when running without debugger support. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: parens Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index e209d3b89865c6a7a2c6bd967e984db8f8c6e3c2..ccc5309e1fdf30083f898bffe19852b472797791 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -1339,12 +1339,13 @@ static const MethodParameter* get_stack_params[] = {
static bool GetStack(Thread* thread, JSONStream* js) {
- if (!thread->isolate()->compilation_allowed()) {
+ Isolate* isolate = thread->isolate();
+ if (isolate->debugger() == NULL) {
js->PrintError(kFeatureDisabled,
- "Cannot get stack when running a precompiled program.");
+ "Cannot get stack when debugger disabled.");
return true;
}
- Isolate* isolate = thread->isolate();
+ ASSERT(isolate->compilation_allowed());
DebuggerStackTrace* stack = isolate->debugger()->StackTrace();
// Do we want the complete script object and complete local variable objects?
// This is true for dump requests.
« no previous file with comments | « runtime/vm/isolate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698