Issue 2180573002: Try to fix crash because of InlineBox deletion in a cached subsequence

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2180573002: Try to fix crash because of InlineBox deletion in a cached subsequence (Closed)

Created:
4 years, 5 months ago by Xianzhu

Modified:
4 years, 5 months ago

Reviewers:
chrishtr

CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

More Reviews

Description

Try to fix crash because of InlineBox deletion in a cached subsequence Don't know why the crashes occurred on bots. Couldn't reproduce the crashes reported by clusterfuzz locally. Based on the stack, the crash are because of deletion of an InlineBox in a cached subsequence. This partly reverts https://codereview.chromium.org/2160983007/. BUG=619630, 628117 R=chrishtr@chromium.org Review URL: https://codereview.chromium.org/2170583003 . Cr-Commit-Position: refs/heads/master@{#406925}

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -10 lines)			Patch
M	third_party/WebKit/Source/core/layout/LayoutObject.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	third_party/WebKit/Source/core/layout/api/LineLayoutItem.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/layout/line/InlineBox.cpp	View	1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Xianzhu

4 years, 5 months ago (2016-07-22 22:12:08 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
83829c7315e1e4949305c63888258e05742f258d.

Expand Messages | Collapse Messages