Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2170583003: Try to fix crash because of InlineBox deletion in a cached subsequence (Closed)

Created:
4 years, 5 months ago by Xianzhu
Modified:
4 years, 5 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try to fix crash because of InlineBox deletion in a cached subsequence Don't know why the crashes occurred on bots. Couldn't reproduce the crashes reported by clusterfuzz locally. Based on the stack, the crash are because of deletion of an InlineBox in a cached subsequence. This partly reverts https://codereview.chromium.org/2160983007/. BUG=619630, 628117 R=chrishtr@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/f6c6259fca56e59fdb6d420f6d809d2c6c8cbdca

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LineLayoutItem.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.cpp View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Xianzhu
4 years, 5 months ago (2016-07-20 22:05:04 UTC) #5
chrishtr
lgtm
4 years, 5 months ago (2016-07-21 17:03:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170583003/20001
4 years, 5 months ago (2016-07-21 17:03:34 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f6c6259fca56e59fdb6d420f6d809d2c6c8cbdca Cr-Commit-Position: refs/heads/master@{#406925}
4 years, 5 months ago (2016-07-21 19:01:11 UTC) #16
Xianzhu
4 years, 5 months ago (2016-07-21 19:02:18 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f6c6259fca56e59fdb6d420f6d809d2c6c8cbdca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698