Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2180483003: Convert XYZ values from PNGs to D50 (Closed)

Created:
4 years, 5 months ago by msarett
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Convert XYZ values from PNGs to D50 Previously, we were storing whatever values we got out of the file and pretending they were D50. Brian has demonstrated that this doesn't really work. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2180483003 Committed: https://skia.googlesource.com/skia/+/554479527c669733ea0ef6c1dedd2c9d1773d784

Patch Set 1 #

Patch Set 2 : Preemptively fix windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -19 lines) Patch
M src/codec/SkPngCodec.cpp View 1 5 chunks +80 lines, -19 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
msarett
4 years, 5 months ago (2016-07-22 20:06:40 UTC) #4
Brian Osman
This fixed the white-point issues I was seeing in my gamut conversion code, so yay! ...
4 years, 5 months ago (2016-07-22 20:16:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180483003/40001
4 years, 5 months ago (2016-07-22 21:06:34 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 21:07:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/554479527c669733ea0ef6c1dedd2c9d1773d784

Powered by Google App Engine
This is Rietveld 408576698