Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2180333002: Fix yasm for Android build (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16039 lines) Patch
M gyp/libjpeg-turbo.gyp View 1 2 chunks +12 lines, -1 line 0 comments Download
A third_party/yasm/android/yasm View 1 Binary file 0 comments Download
D third_party/yasm/config/android/Makefile View 1 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/config/android/config.h View 1 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/config/android/libyasm-stdint.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/config/chromeos/Makefile View 1 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/config/chromeos/config.h View 1 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/config/chromeos/libyasm-stdint.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/config/openbsd/Makefile View 1 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/config/openbsd/config.h View 1 1 chunk +0 lines, -165 lines 0 comments Download
D third_party/yasm/config/openbsd/libyasm-stdint.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/config/win/Makefile View 1 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/config/win/config.h View 1 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/config/win/libyasm-stdint.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/config/win/stdint.h View 1 1 chunk +0 lines, -30 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
msarett
Here's a band-aid fix - checking in the yasm binary. Strangely, my local GCC build ...
4 years, 4 months ago (2016-07-26 17:40:20 UTC) #3
msarett
FWIW, I grabbed this binary from Android's prebuilts. This is how Android uses yasm.
4 years, 4 months ago (2016-07-26 17:41:11 UTC) #4
msarett
Another comment: I actually figured out the cause of my broken gcc build (it was ...
4 years, 4 months ago (2016-07-26 17:52:18 UTC) #5
mtklein
lgtm
4 years, 4 months ago (2016-07-26 17:55:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180333002/20001
4 years, 4 months ago (2016-07-26 17:56:01 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 18:24:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/dc2257bfab9fc232f96c6db0595b9d12b2f0cf36

Powered by Google App Engine
This is Rietveld 408576698