chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 2180293002: Remove the print option from the menu and make it a share destination.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2180293002: Remove the print option from the menu and make it a share destination. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/values/ids.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index a415606bd43b47f7e16bd0cf7b603d2f5789bdc1..8eb3a01f94e7daf0c7bd301b62dbd50af8927845 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -92,6 +92,7 @@ import org.chromium.chrome.browser.partnercustomizations.PartnerBrowserCustomiza

import org.chromium.chrome.browser.preferences.ChromePreferenceManager;

import org.chromium.chrome.browser.preferences.PrefServiceBridge;

import org.chromium.chrome.browser.preferences.PreferencesLauncher;

+import org.chromium.chrome.browser.printing.PrintShareActivity;

import org.chromium.chrome.browser.printing.TabPrinter;

import org.chromium.chrome.browser.share.ShareHelper;

import org.chromium.chrome.browser.snackbar.DataUseSnackbarController;

@@ -958,6 +959,12 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

final Tab currentTab = getActivityTab();

if (currentTab == null) return;

+ PrintingController printingController = getChromeApplication().getPrintingController();

+ if (printingController != null && !currentTab.isNativePage() && !printingController.isBusy()

+ && PrefServiceBridge.getInstance().isPrintingEnabled()) {

+ PrintShareActivity.enablePrintShareOption(this);

+ }

final Activity mainActivity = this;

ContentBitmapCallback callback = new ContentBitmapCallback() {

@Override