chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc - Issue 2180253003: Ensure BrowserThread::CurrentlyOn is correct through MessageLoop teardown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc

Issue 2180253003: Ensure BrowserThread::CurrentlyOn is correct through MessageLoop teardown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix that test for reals Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc ('k') | chrome/browser/safe_browsing/protocol_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc

index 6f6c2290648a3ccb0bc77d981e7e4b2ab527c19d..6c70edcec54d87bbb22617ee5ffc8bdd85a75ddc 100644

--- a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc

@@ -196,7 +196,7 @@ class IncidentReportingServiceTest : public testing::Test {

IncidentReportingServiceTest()

: task_runner_(new base::TestSimpleTaskRunner),

thread_task_runner_handle_(task_runner_),

- ui_thread_(content::BrowserThread::UI),

+ ui_thread_(content::BrowserThread::UI, base::MessageLoop::current()),

profile_manager_(TestingBrowserProcess::GetGlobal()),

on_create_download_finder_action_(

ON_CREATE_DOWNLOAD_FINDER_DOWNLOADS_FOUND),