Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4811)

Unified Diff: chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

Issue 2180253003: Ensure BrowserThread::CurrentlyOn is correct through MessageLoop teardown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix that test for reals Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc
diff --git a/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc b/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc
index fa734bcedea523accad4bd0a352009b8404e290d..cdf8e3c6962d646e407328d92f04dfff1d194403 100644
--- a/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc
+++ b/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc
@@ -138,6 +138,11 @@ class ComponentCloudPolicyTest : public ExtensionBrowserTest {
ExtensionBrowserTest::SetUpOnMainThread();
}
+ void TearDownOnMainThread() override {
+ event_listener_.reset();
+ ExtensionBrowserTest::TearDownOnMainThread();
+ }
+
scoped_refptr<const extensions::Extension> LoadExtension(
const base::FilePath::CharType* path) {
base::FilePath full_path;
@@ -256,6 +261,9 @@ IN_PROC_BROWSER_TEST_F(ComponentCloudPolicyTest, UpdateExtensionPolicy) {
}
IN_PROC_BROWSER_TEST_F(ComponentCloudPolicyTest, InstallNewExtension) {
+ event_listener_->Reply("idle");
+ event_listener_.reset();
+
EXPECT_TRUE(test_server_.UpdatePolicyData(
dm_protocol::kChromeExtensionPolicyType, kTestExtension2, kTestPolicy2));
// Installing a new extension doesn't trigger another policy fetch because

Powered by Google App Engine
This is Rietveld 408576698