Make sure the Async test cases availabel today generate correct ClientID.

Make sure the Async test cases availabel today generate correct ClientID.

BUG=630817
Committed: https://crrev.com/fa953a82b27d712228289c6238b671e900fc1221
Cr-Commit-Position: refs/heads/master@{#408410}

[Dmitry Titov, 2016-07-27 01:01:36]

dimich@chromium.org changed reviewers:
+ chili@chromium.org, fgorski@chromium.org

[Dmitry Titov, 2016-07-27 01:01:36]

Adding Guids at entry points for creating async_loading pages. WIP.

[fgorski, 2016-07-27 15:45:32]

lgtm

[chili, 2016-07-27 18:40:47]

lgtm

https://codereview.chromium.org/2180113003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
(right):

https://codereview.chromium.org/2180113003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java:173:
// Download UI needs "async_loading" namespace and a type 4 (random) GUID.
nit: can we leave out the 'type 4' in the comments?  Nothing in the code refers
to this as a type 4 GUID, which makes this confusing.  Can also do 'a random
(type 4) GUID' as well

https://codereview.chromium.org/2180113003/diff/1/chrome/browser/ui/webui/off...
File chrome/browser/ui/webui/offline_internals_ui.cc (right):

https://codereview.chromium.org/2180113003/diff/1/chrome/browser/ui/webui/off...
chrome/browser/ui/webui/offline_internals_ui.cc:340: // To be visible in
Downloads UI, these items need a well-formed GUILD
nit: should this say "GUI ID"? or "GUID"?

[Dmitry Titov, 2016-07-27 19:50:48]

dimich@chromium.org changed reviewers:
+ bauerb@chromium.org

[Dmitry Titov, 2016-07-27 19:50:49]

PTAL 
+bauerb@ for OWNER's look at java and webui changes.

https://codereview.chromium.org/2180113003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
(right):

https://codereview.chromium.org/2180113003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java:173:
// Download UI needs "async_loading" namespace and a type 4 (random) GUID.
On 2016/07/27 18:40:47, chili wrote:
> nit: can we leave out the 'type 4' in the comments?  Nothing in the code
refers
> to this as a type 4 GUID, which makes this confusing.  Can also do 'a random
> (type 4) GUID' as well

Done.

https://codereview.chromium.org/2180113003/diff/1/chrome/browser/ui/webui/off...
File chrome/browser/ui/webui/offline_internals_ui.cc (right):

https://codereview.chromium.org/2180113003/diff/1/chrome/browser/ui/webui/off...
chrome/browser/ui/webui/offline_internals_ui.cc:340: // To be visible in
Downloads UI, these items need a well-formed GUILD
On 2016/07/27 18:40:47, chili wrote:
> nit: should this say "GUI ID"? or "GUID"?

Done.

[Bernhard Bauer, 2016-07-28 09:23:30]

lgtm

[Dmitry Titov, 2016-07-28 15:51:30]

The CQ bit was checked by dimich@chromium.org

[Dmitry Titov, 2016-07-28 15:51:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
fgorski@chromium.org, chili@chromium.org
Link to the patchset: https://codereview.chromium.org/2180113003/#ps20001
(title: "updated per CR comments")

[commit-bot: I haz the power, 2016-07-28 15:51:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 17:23:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-28 17:25:36]

Description was changed from

==========
Make sure the Async test cases availabel today generate correct ClientID.

BUG=630817
==========

to

==========
Make sure the Async test cases availabel today generate correct ClientID.

BUG=630817

Committed: https://crrev.com/fa953a82b27d712228289c6238b671e900fc1221
Cr-Commit-Position: refs/heads/master@{#408410}
==========

[commit-bot: I haz the power, 2016-07-28 17:25:37]

Patchset 2 (id:??) landed as
https://crrev.com/fa953a82b27d712228289c6238b671e900fc1221
Cr-Commit-Position: refs/heads/master@{#408410}