components/offline_pages/background/request_coordinator.cc - Issue 2180113003: Make sure the Async test cases availabel today generate correct ClientID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_coordinator.cc

Issue 2180113003: Make sure the Async test cases availabel today generate correct ClientID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated per CR comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/offline_pages/background/request_coordinator.cc

diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc

index df8bad99d3412380165ee7c2dc668cb530c22625..bfe08bd3609812ddbb35c3cc2d45b11638d5b190 100644

--- a/components/offline_pages/background/request_coordinator.cc

+++ b/components/offline_pages/background/request_coordinator.cc

@@ -62,8 +62,7 @@ bool RequestCoordinator::SavePageLater(

const GURL& url, const ClientId& client_id, bool was_user_requested) {

DVLOG(2) << "URL is " << url << " " << __FUNCTION__;

- // TODO(petewil): We need a robust scheme for allocating new IDs. We may need

- // GUIDS for the downloads home design.

+ // TODO(petewil): We need a robust scheme for allocating new IDs.

static int64_t id = 0;

// Build a SavePageRequest.

« no previous file with comments | « chrome/browser/ui/webui/offline_internals_ui.cc ('k') | no next file » | no next file with comments »