Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2180003004: Remove inability to call QuicSimpleServerPacketWriter::WritePacket directly (Closed)

Created:
4 years, 4 months ago by rjshade
Modified:
4 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove inability to call QuicSimpleServerPacketWriter::WritePacket directly. Fixes toy server crash described here: https://groups.google.com/a/chromium.org/forum/#!topic/proto-quic/ziwUgZbV2Wk BUG= Committed: https://crrev.com/eb96532b4d2dd950cb6d870cc4b04092f54006bb Cr-Commit-Position: refs/heads/master@{#408221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M net/tools/quic/quic_simple_server_packet_writer.h View 2 chunks +13 lines, -17 lines 0 comments Download
M net/tools/quic/quic_simple_server_packet_writer.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
rjshade
4 years, 4 months ago (2016-07-26 21:06:54 UTC) #3
Ryan Hamilton
lgtm This feels scary to me, but I cant' find anything wrong with this, and ...
4 years, 4 months ago (2016-07-27 19:28:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2180003004/1
4 years, 4 months ago (2016-07-27 19:28:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 20:01:10 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 20:02:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb96532b4d2dd950cb6d870cc4b04092f54006bb
Cr-Commit-Position: refs/heads/master@{#408221}

Powered by Google App Engine
This is Rietveld 408576698