Remove inability to call QuicSimpleServerPacketWriter::WritePacket directly

net/tools/quic/quic_simple_server_packet_writer.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_TOOLS_QUIC_SIMPLE_SERVER_PACKET_WRITER_H_
 #define NET_QUIC_TOOLS_QUIC_SIMPLE_SERVER_PACKET_WRITER_H_
 
 #include <stddef.h>
 
 #include "base/callback.h"
@@ skipping 15 matching lines @@
 // Chrome specific packet writer which uses a UDPServerSocket for writing
 // data.
 class QuicSimpleServerPacketWriter : public QuicPacketWriter {
  public:
   typedef base::Callback<void(WriteResult)> WriteCallback;
 
   QuicSimpleServerPacketWriter(UDPServerSocket* socket,
                                QuicBlockedWriterInterface* blocked_writer);
   ~QuicSimpleServerPacketWriter() override;
 
-  // Use this method to write packets rather than WritePacket:
-  // QuicSimpleServerPacketWriter requires a callback to exist for every
-  // write, which will be called once the write completes.
-  virtual WriteResult WritePacketWithCallback(const char* buffer,
-                                              size_t buf_len,
-                                              const IPAddress& self_address,
-                                              const IPEndPoint& peer_address,
-                                              PerPacketOptions* options,
-                                              WriteCallback callback);
+  // Wraps WritePacket, and ensures that |callback| is run on successful write.
+  WriteResult WritePacketWithCallback(const char* buffer,
+                                      size_t buf_len,
+                                      const IPAddress& self_address,
+                                      const IPEndPoint& peer_address,
+                                      PerPacketOptions* options,
+                                      WriteCallback callback);
+
+  WriteResult WritePacket(const char* buffer,
+                          size_t buf_len,
+                          const IPAddress& self_address,
+                          const IPEndPoint& peer_address,
+                          PerPacketOptions* options) override;
 
   void OnWriteComplete(int rv);
 
   // QuicPacketWriter implementation:
   bool IsWriteBlockedDataBuffered() const override;
   bool IsWriteBlocked() const override;
   void SetWritable() override;
   QuicByteCount GetMaxPacketSize(const IPEndPoint& peer_address) const override;
 
- protected:
-  // Do not call WritePacket on its own -- use WritePacketWithCallback
-  WriteResult WritePacket(const char* buffer,
-                          size_t buf_len,
-                          const IPAddress& self_address,
-                          const IPEndPoint& peer_address,
-                          PerPacketOptions* options) override;
-
  private:
   UDPServerSocket* socket_;
 
   // To be notified after every successful asynchronous write.
   QuicBlockedWriterInterface* blocked_writer_;
 
   // To call once the write completes.
   WriteCallback callback_;
 
   // Whether a write is currently in flight.
   bool write_blocked_;
 
   base::WeakPtrFactory<QuicSimpleServerPacketWriter> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicSimpleServerPacketWriter);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_TOOLS_QUIC_SIMPLE_SERVER_PACKET_WRITER_H_