Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 2179903007: Delete remaining leftover files in //device/geolocation (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
mcasas, Paul Stewart
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete remaining leftover files in //device/geolocation These were left behind by a bad revert in https://codereview.chromium.org/2188933002. Deleting them completely reverts the changes in https://codereview.chromium.org/2185993003, and fixes DEPS failures on the Linux Tests bot. BUG=612334 TBR=pstew@chromium.org,mcasas@chromium.org Committed: https://crrev.com/443e536b532688a5f1cb64fe99098ccaaa81e399 Cr-Commit-Position: refs/heads/master@{#408332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1964 lines) Patch
D device/geolocation/wifi_data_provider_common_win.h View 1 chunk +0 lines, -24 lines 0 comments Download
D device/geolocation/wifi_data_provider_common_win.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D device/geolocation/wifi_data_provider_corewlan_mac.mm View 1 chunk +0 lines, -192 lines 0 comments Download
D device/geolocation/wifi_data_provider_linux.h View 1 chunk +0 lines, -41 lines 0 comments Download
D device/geolocation/wifi_data_provider_linux.cc View 1 chunk +0 lines, -381 lines 0 comments Download
D device/geolocation/wifi_data_provider_linux_unittest.cc View 1 chunk +0 lines, -237 lines 0 comments Download
D device/geolocation/wifi_data_provider_mac.h View 1 chunk +0 lines, -36 lines 0 comments Download
D device/geolocation/wifi_data_provider_mac.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D device/geolocation/wifi_data_provider_manager.h View 1 chunk +0 lines, -97 lines 0 comments Download
D device/geolocation/wifi_data_provider_manager.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D device/geolocation/wifi_data_provider_win.h View 1 chunk +0 lines, -31 lines 0 comments Download
D device/geolocation/wifi_data_provider_win.cc View 1 chunk +0 lines, -643 lines 0 comments Download
D device/geolocation/wifi_data_provider_win_unittest.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D device/geolocation/wifi_polling_policy.h View 1 chunk +0 lines, -57 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
tsergeant
This is the last patch to fix up the revert (verified by carefully checking the ...
4 years, 4 months ago (2016-07-28 03:10:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179903007/1
4 years, 4 months ago (2016-07-28 03:10:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 03:49:24 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 03:52:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/443e536b532688a5f1cb64fe99098ccaaa81e399
Cr-Commit-Position: refs/heads/master@{#408332}

Powered by Google App Engine
This is Rietveld 408576698