Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2179903006: DocumentThreadableLoader should clear its Resource before destruction (Closed)

Created:
4 years, 4 months ago by yhirano
Modified:
4 years, 4 months ago
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DocumentThreadableLoader should clear its Resource before destruction This CL makes sure that DocumentThreadableLoader's associated Resource is always cleared before destruction. BUG=587663 Committed: https://crrev.com/7b53267a2d52ee4449732076860fbfe344852f6e Cr-Commit-Position: refs/heads/master@{#409714}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 1 3 chunks +5 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (12 generated)
yhirano
Note: A DocumentThreadableLoader can assume the loading is completed when it's destroyed: see https://codereview.chromium.org/2146403004/.
4 years, 4 months ago (2016-07-28 03:45:49 UTC) #10
tyoshino (SeeGerritForStatus)
lgtm
4 years, 4 months ago (2016-07-28 07:50:59 UTC) #11
yhirano
Nate: ping
4 years, 4 months ago (2016-08-01 07:58:33 UTC) #12
Nate Chapin
lgtm
4 years, 4 months ago (2016-08-03 18:15:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179903006/20001
4 years, 4 months ago (2016-08-04 00:52:14 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 03:26:27 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 03:30:00 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b53267a2d52ee4449732076860fbfe344852f6e
Cr-Commit-Position: refs/heads/master@{#409714}

Powered by Google App Engine
This is Rietveld 408576698