Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2179903003: This CL implements the gamepads wayland API. Since js device nodes on linux can be opened multiple … (Closed)

Created:
4 years, 5 months ago by denniskempin
Modified:
4 years, 5 months ago
Reviewers:
reveman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

This CL implements the gamepads wayland API. Since js device nodes on linux can be opened multiple times, we are not required to go through the content::GamepadService, but can directly use our own device::GamepadPlatformDataFetcher in our own polling thread. The polling thread will compare the newly fetched data to the previous data and send any changes as events to the wayland client. BUG=620977 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2076013002 Cr-Commit-Position: refs/heads/master@{#405356} (cherry picked from commit 68de182439eed91857dafbb4348f1e4857b18c69)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+721 lines, -2 lines) Patch
M components/exo.gypi View 3 chunks +4 lines, -0 lines 0 comments Download
M components/exo/BUILD.gn View 5 chunks +7 lines, -0 lines 0 comments Download
M components/exo/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A components/exo/gamepad.h View 1 chunk +71 lines, -0 lines 0 comments Download
A components/exo/gamepad.cc View 1 chunk +265 lines, -0 lines 0 comments Download
A components/exo/gamepad_delegate.h View 1 chunk +46 lines, -0 lines 0 comments Download
A components/exo/gamepad_unittest.cc View 1 chunk +221 lines, -0 lines 0 comments Download
M components/exo/wayland/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/exo/wayland/server.cc View 5 chunks +100 lines, -0 lines 0 comments Download
M device/gamepad/gamepad_data_fetcher.h View 2 chunks +2 lines, -1 line 0 comments Download
M device/gamepad/gamepad_platform_data_fetcher_linux.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
reveman
lgtm
4 years, 5 months ago (2016-07-25 20:47:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179903003/1
4 years, 5 months ago (2016-07-25 20:52:05 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 21:09:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698