ARC: Avoid duplicate observers in IME service

ARC: Avoid duplicate observers in IME service

Root windows share the same FocusClient in Ash, but the ARC IME service
registers one FocusClient observer per root window.

BUG=631136
TEST=Dragging an Exo window to a secondary display does not DCHECK.
TEST=Typing into ARC apps using a French keyboard still works.

Committed: https://crrev.com/8b69fb4d6a4ced6df9c967a092a4f5b575333374
Cr-Commit-Position: refs/heads/master@{#407900}

[Dominik Laskowski, 2016-07-25 18:44:45]

domlaskowski@chromium.org changed reviewers:
+ kinaba@chromium.org, oshima@chromium.org

[Dominik Laskowski, 2016-07-25 18:45:51]

The CQ bit was checked by domlaskowski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 18:46:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2016-07-25 19:13:01]

lgtm

https://codereview.chromium.org/2179903002/diff/1/components/arc/ime/arc_ime_...
File components/arc/ime/arc_ime_service.cc (right):

https://codereview.chromium.org/2179903002/diff/1/components/arc/ime/arc_ime_...
components/arc/ime/arc_ime_service.cc:101: if (keyboard_controller &&
keyboard_controller_ != keyboard_controller) {
does this mean that the keyboard_controller_ pointer is stale?

[commit-bot: I haz the power, 2016-07-25 19:19:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 19:19:14]

Dry run: This issue passed the CQ dry run.

[Dominik Laskowski, 2016-07-25 19:54:18]

https://codereview.chromium.org/2179903002/diff/1/components/arc/ime/arc_ime_...
File components/arc/ime/arc_ime_service.cc (right):

https://codereview.chromium.org/2179903002/diff/1/components/arc/ime/arc_ime_...
components/arc/ime/arc_ime_service.cc:101: if (keyboard_controller &&
keyboard_controller_ != keyboard_controller) {
On 2016/07/25 19:13:00, oshima wrote:
> does this mean that the keyboard_controller_ pointer is stale?

Yes, it can be stale after a call to KeyboardController::ResetInstance. Note
that this CL assumes that the Shell's FocusClient lives longer than the
ArcImeService. Otherwise, focus_client_ could be a stray pointer on destruction.

[kinaba, 2016-07-25 21:37:39]

lgtm

thanks!

[Dominik Laskowski, 2016-07-25 22:36:50]

The CQ bit was checked by domlaskowski@chromium.org

[commit-bot: I haz the power, 2016-07-25 22:37:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 22:44:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 22:44:10]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dominik Laskowski, 2016-07-25 22:48:09]

domlaskowski@chromium.org changed reviewers:
+ lhchavez@chromium.org

[Dominik Laskowski, 2016-07-25 22:48:09]

+Luis for OWNERS approval.

[Luis Héctor Chávez, 2016-07-26 19:51:22]

rs-lgtm

[Dominik Laskowski, 2016-07-26 19:52:51]

The CQ bit was checked by domlaskowski@chromium.org

[commit-bot: I haz the power, 2016-07-26 19:53:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 20:30:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-26 20:32:01]

Description was changed from

==========
ARC: Avoid duplicate observers in IME service

Root windows share the same FocusClient in Ash, but the ARC IME service
registers one FocusClient observer per root window.

BUG=631136
TEST=Dragging an Exo window to a secondary display does not DCHECK.
TEST=Typing into ARC apps using a French keyboard still works.
==========

to

==========
ARC: Avoid duplicate observers in IME service

Root windows share the same FocusClient in Ash, but the ARC IME service
registers one FocusClient observer per root window.

BUG=631136
TEST=Dragging an Exo window to a secondary display does not DCHECK.
TEST=Typing into ARC apps using a French keyboard still works.

Committed: https://crrev.com/8b69fb4d6a4ced6df9c967a092a4f5b575333374
Cr-Commit-Position: refs/heads/master@{#407900}
==========

[commit-bot: I haz the power, 2016-07-26 20:32:03]

Patchset 1 (id:??) landed as
https://crrev.com/8b69fb4d6a4ced6df9c967a092a4f5b575333374
Cr-Commit-Position: refs/heads/master@{#407900}