Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: components/arc/ime/arc_ime_service.h

Issue 2179903002: ARC: Avoid duplicate observers in IME service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_ARC_IME_ARC_IME_SERVICE_H_ 5 #ifndef COMPONENTS_ARC_IME_ARC_IME_SERVICE_H_
6 #define COMPONENTS_ARC_IME_ARC_IME_SERVICE_H_ 6 #define COMPONENTS_ARC_IME_ARC_IME_SERVICE_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "components/arc/arc_service.h" 11 #include "components/arc/arc_service.h"
12 #include "components/arc/ime/arc_ime_bridge.h" 12 #include "components/arc/ime/arc_ime_bridge.h"
13 #include "ui/aura/client/focus_change_observer.h" 13 #include "ui/aura/client/focus_change_observer.h"
14 #include "ui/aura/env_observer.h" 14 #include "ui/aura/env_observer.h"
15 #include "ui/aura/window_observer.h" 15 #include "ui/aura/window_observer.h"
16 #include "ui/aura/window_tracker.h" 16 #include "ui/aura/window_tracker.h"
17 #include "ui/base/ime/text_input_client.h" 17 #include "ui/base/ime/text_input_client.h"
18 #include "ui/base/ime/text_input_flags.h" 18 #include "ui/base/ime/text_input_flags.h"
19 #include "ui/base/ime/text_input_type.h" 19 #include "ui/base/ime/text_input_type.h"
20 #include "ui/gfx/geometry/rect.h" 20 #include "ui/gfx/geometry/rect.h"
21 #include "ui/keyboard/keyboard_controller.h" 21 #include "ui/keyboard/keyboard_controller.h"
22 #include "ui/keyboard/keyboard_controller_observer.h" 22 #include "ui/keyboard/keyboard_controller_observer.h"
23 23
24 namespace aura { 24 namespace aura {
25 namespace client {
26 class FocusClient;
27 }
28
25 class Window; 29 class Window;
26 } 30 }
27 31
28 namespace ui { 32 namespace ui {
29 class InputMethod; 33 class InputMethod;
30 } 34 }
31 35
32 namespace arc { 36 namespace arc {
33 37
34 class ArcBridgeService; 38 class ArcBridgeService;
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 } 111 }
108 112
109 private: 113 private:
110 ui::InputMethod* GetInputMethod(); 114 ui::InputMethod* GetInputMethod();
111 115
112 std::unique_ptr<ArcImeBridge> ime_bridge_; 116 std::unique_ptr<ArcImeBridge> ime_bridge_;
113 ui::TextInputType ime_type_; 117 ui::TextInputType ime_type_;
114 gfx::Rect cursor_rect_; 118 gfx::Rect cursor_rect_;
115 bool has_composition_text_; 119 bool has_composition_text_;
116 120
117 aura::WindowTracker observing_root_windows_;
118 aura::WindowTracker arc_windows_; 121 aura::WindowTracker arc_windows_;
119 aura::WindowTracker focused_arc_window_; 122 aura::WindowTracker focused_arc_window_;
120 123
124 aura::client::FocusClient* focus_client_;
121 keyboard::KeyboardController* keyboard_controller_; 125 keyboard::KeyboardController* keyboard_controller_;
122 126
123 ui::InputMethod* test_input_method_; 127 ui::InputMethod* test_input_method_;
124 128
125 DISALLOW_COPY_AND_ASSIGN(ArcImeService); 129 DISALLOW_COPY_AND_ASSIGN(ArcImeService);
126 }; 130 };
127 131
128 } // namespace arc 132 } // namespace arc
129 133
130 #endif // COMPONENTS_ARC_IME_ARC_IME_SERVICE_H_ 134 #endif // COMPONENTS_ARC_IME_ARC_IME_SERVICE_H_
OLDNEW
« no previous file with comments | « no previous file | components/arc/ime/arc_ime_service.cc » ('j') | components/arc/ime/arc_ime_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698