customtabs: Histograms for special sessions prerendering.

customtabs: Histograms for special sessions prerendering.

Custom Tabs has special cases with respect to prerendering, for
prerendering throttling and URL matching.

This introduces two new histograms to track how common these special
sessions are, and how many special prerenders are later matched by a URL load.

Committed: https://crrev.com/efa7dba88b2ad42eba2de61522cb45b7f70b2437
Cr-Commit-Position: refs/heads/master@{#409234}

[Benoit L, 2016-07-25 14:31:15]

lizeb@chromium.org changed reviewers:
+ isherman@chromium.org, yusufo@chromium.org

[Ilya Sherman, 2016-07-25 18:47:34]

https://codereview.chromium.org/2179783002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2179783002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:7298: +<histogram
name="CustomTabs.PrerenderSessionIsSpecial" enum="Boolean">
nit: Is "special" really the term that you're using within the team to refer to
these sessions?  It seems like a more descriptive term might have better
longevity.

https://codereview.chromium.org/2179783002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:7298: +<histogram
name="CustomTabs.PrerenderSessionIsSpecial" enum="Boolean">
nit: Please use a custom enum with more specific labels than just true/false
(just within histograms.xml, no need to change anything in the C++ code)

https://codereview.chromium.org/2179783002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:7307: +<histogram
name="CustomTabs.SpecialSessionPrerenderMatched" enum="Boolean">
nit: Ditto for this enum.

[Yusuf, 2016-08-01 20:34:38]

lgtm

https://codereview.chromium.org/2179783002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java
(right):

https://codereview.chromium.org/2179783002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java:97:

javadoc

https://codereview.chromium.org/2179783002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
(right):

https://codereview.chromium.org/2179783002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java:470:
if (mClientManager.isSpecialSession(session) && webContents != null) {
Nonstandard? Or have a call that says isStandard and only record the values as
non-standard?

I kinda agree that special is not the best word here.

[Benoit L, 2016-08-02 16:10:24]

Thanks!
All done.

isherman, PTAL,

https://codereview.chromium.org/2179783002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java
(right):

https://codereview.chromium.org/2179783002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java:97:

On 2016/08/01 20:34:38, Yusuf wrote:
> javadoc

Done.

https://codereview.chromium.org/2179783002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
(right):

https://codereview.chromium.org/2179783002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java:470:
if (mClientManager.isSpecialSession(session) && webContents != null) {
On 2016/08/01 20:34:38, Yusuf wrote:
> Nonstandard? Or have a call that says isStandard and only record the values as
> non-standard?
> 
> I kinda agree that special is not the best word here.

Done.

https://codereview.chromium.org/2179783002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2179783002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:7298: +<histogram
name="CustomTabs.PrerenderSessionIsSpecial" enum="Boolean">
On 2016/07/25 18:47:34, Ilya Sherman wrote:
> nit: Is "special" really the term that you're using within the team to refer
to
> these sessions?  It seems like a more descriptive term might have better
> longevity.

Done.

https://codereview.chromium.org/2179783002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:7298: +<histogram
name="CustomTabs.PrerenderSessionIsSpecial" enum="Boolean">
On 2016/07/25 18:47:34, Ilya Sherman wrote:
> nit: Please use a custom enum with more specific labels than just true/false
> (just within histograms.xml, no need to change anything in the C++ code)

Done.

https://codereview.chromium.org/2179783002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:7307: +<histogram
name="CustomTabs.SpecialSessionPrerenderMatched" enum="Boolean">
On 2016/07/25 18:47:34, Ilya Sherman wrote:
> nit: Ditto for this enum.

Done.

[Ilya Sherman, 2016-08-02 16:16:00]

metrics lgtm, thanks

[Benoit L, 2016-08-02 16:16:49]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 16:17:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 17:21:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 17:21:56]

Dry run: This issue passed the CQ dry run.

[Benoit L, 2016-08-02 17:50:44]

The CQ bit was checked by lizeb@chromium.org

[Benoit L, 2016-08-02 17:50:45]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org
Link to the patchset: https://codereview.chromium.org/2179783002/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-08-02 17:51:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 17:56:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-02 17:57:52]

Description was changed from

==========
customtabs: Histograms for special sessions prerendering.

Custom Tabs has special cases with respect to prerendering, for
prerendering throttling and URL matching.

This introduces two new histograms to track how common these special
sessions are, and how many special prerenders are later matched by a URL load.
==========

to

==========
customtabs: Histograms for special sessions prerendering.

Custom Tabs has special cases with respect to prerendering, for
prerendering throttling and URL matching.

This introduces two new histograms to track how common these special
sessions are, and how many special prerenders are later matched by a URL load.

Committed: https://crrev.com/efa7dba88b2ad42eba2de61522cb45b7f70b2437
Cr-Commit-Position: refs/heads/master@{#409234}
==========

[commit-bot: I haz the power, 2016-08-02 17:57:53]

Patchset 2 (id:??) landed as
https://crrev.com/efa7dba88b2ad42eba2de61522cb45b7f70b2437
Cr-Commit-Position: refs/heads/master@{#409234}