Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2179783002: customtabs: Histograms for special sessions prerendering. (Closed)

Created:
4 years, 5 months ago by Benoit L
Modified:
4 years, 4 months ago
Reviewers:
Yusuf, Ilya Sherman
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Histograms for special sessions prerendering. Custom Tabs has special cases with respect to prerendering, for prerendering throttling and URL matching. This introduces two new histograms to track how common these special sessions are, and how many special prerenders are later matched by a URL load. Committed: https://crrev.com/efa7dba88b2ad42eba2de61522cb45b7f70b2437 Cr-Commit-Position: refs/heads/master@{#409234}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java View 1 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java View 1 3 chunks +13 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 3 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Benoit L
4 years, 5 months ago (2016-07-25 14:31:16 UTC) #2
Ilya Sherman
https://codereview.chromium.org/2179783002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2179783002/diff/1/tools/metrics/histograms/histograms.xml#newcode7298 tools/metrics/histograms/histograms.xml:7298: +<histogram name="CustomTabs.PrerenderSessionIsSpecial" enum="Boolean"> nit: Is "special" really the term ...
4 years, 5 months ago (2016-07-25 18:47:34 UTC) #3
Yusuf
lgtm https://codereview.chromium.org/2179783002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java (right): https://codereview.chromium.org/2179783002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java#newcode97 chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java:97: javadoc https://codereview.chromium.org/2179783002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java (right): https://codereview.chromium.org/2179783002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java#newcode470 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java:470: if ...
4 years, 4 months ago (2016-08-01 20:34:38 UTC) #4
Benoit L
Thanks! All done. isherman, PTAL, https://codereview.chromium.org/2179783002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java (right): https://codereview.chromium.org/2179783002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java#newcode97 chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java:97: On 2016/08/01 20:34:38, Yusuf ...
4 years, 4 months ago (2016-08-02 16:10:24 UTC) #5
Ilya Sherman
metrics lgtm, thanks
4 years, 4 months ago (2016-08-02 16:16:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179783002/20001
4 years, 4 months ago (2016-08-02 17:51:34 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 17:56:16 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 17:57:53 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/efa7dba88b2ad42eba2de61522cb45b7f70b2437
Cr-Commit-Position: refs/heads/master@{#409234}

Powered by Google App Engine
This is Rietveld 408576698