tools/metrics/histograms/histograms.xml - Issue 2179783002: customtabs: Histograms for special sessions prerendering.

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2179783002: customtabs: Histograms for special sessions prerendering. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index c6ba576435227b9823cd0e9ee2ac6cd736c9e7b5..5e15dd1feb67e08c8c1c2e83863a72d4b7b93d63 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -7295,6 +7295,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="CustomTabs.PrerenderSessionIsSpecial" enum="Boolean">

Ilya Sherman 2016/07/25 18:47:34 nit: Is "special" really the term that you're usin

Ilya Sherman 2016/07/25 18:47:34 nit: Please use a custom enum with more specific l

Benoit L 2016/08/02 16:10:24 Done.

+ <owner>lizeb@chromium.org</owner>

+ <summary>

+ Android: When prerendering a URL for Custom Tabs, whether the client session

+ is a special one (that is, ignoring fragments and enabled on cellular

+ connections).

+ </summary>

+</histogram>

+<histogram name="CustomTabs.SpecialSessionPrerenderMatched" enum="Boolean">

Ilya Sherman 2016/07/25 18:47:34 nit: Ditto for this enum.

Benoit L 2016/08/02 16:10:24 Done.

+ <owner>lizeb@chromium.org</owner>

+ <summary>

+ Android: When there is a prerender for a special session (that is, ignoring

+ fragments and enabled on cellular connections), whether the prerender was

+ matched when navigating.

+ </summary>

+</histogram>

<owner>yusufo@chromium.org</owner>