Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2179693002: Revert of Convert network hints to Mojo (Closed)

Created:
4 years, 5 months ago by tibell
Modified:
4 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, lcwu+watch_chromium.org, sdefresne+watchlist_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, halliwell+watch_chromium.org, alokp+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, Pat Meenan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert network hints to Mojo (patchset #16 id:300001 of https://codereview.chromium.org/2144533002/ ) BUG=630749 NOPRESUBMIT=true Skipping presubmit as I'm removing OWNERS files I added. Reason for revert: Use-after-free issue: https://bugs.chromium.org/p/chromium/issues/detail?id=630749 Original issue's description: > Convert network hints to Mojo > > Previously landed as: refs/heads/master@{#406780} > > Committed: https://crrev.com/1efd0ad3153587609220eeec1be6c1b2bbf9964b > Cr-Commit-Position: refs/heads/master@{#407030} TBR=sammc@chromium.org,dcheng@chromium.org,juliatuttle@chromium.org,halliwell@chromium.org,sky@chromium.org,mbarbella@chromium.org,blundell@chromium.org,mbarbella@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/0773f761ce9ed103aa297808ac89771bc010d70c Cr-Commit-Position: refs/heads/master@{#407395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+343 lines, -468 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -8 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 4 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 5 chunks +11 lines, -12 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/renderer/chrome_render_thread_observer.h View 4 chunks +0 lines, -13 lines 0 comments Download
M chrome/renderer/chrome_render_thread_observer.cc View 3 chunks +1 line, -9 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.h View 3 chunks +2 lines, -8 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 4 chunks +11 lines, -18 lines 0 comments Download
M components/network_hints.gypi View 4 chunks +7 lines, -44 lines 0 comments Download
M components/network_hints/browser/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M components/network_hints/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D components/network_hints/browser/network_hints_impl.h View 1 chunk +0 lines, -45 lines 0 comments Download
D components/network_hints/browser/network_hints_impl.cc View 1 chunk +0 lines, -86 lines 0 comments Download
A components/network_hints/browser/network_hints_message_filter.h View 1 chunk +40 lines, -0 lines 0 comments Download
A components/network_hints/browser/network_hints_message_filter.cc View 1 chunk +96 lines, -0 lines 0 comments Download
M components/network_hints/common/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
A components/network_hints/common/network_hints_message_generator.h View 1 chunk +7 lines, -0 lines 0 comments Download
A components/network_hints/common/network_hints_message_generator.cc View 1 chunk +39 lines, -0 lines 0 comments Download
A components/network_hints/common/network_hints_messages.h View 1 chunk +50 lines, -0 lines 0 comments Download
A components/network_hints/common/network_hints_messages.cc View 1 chunk +43 lines, -0 lines 0 comments Download
D components/network_hints/public/cpp/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D components/network_hints/public/cpp/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/network_hints/public/cpp/network_hints.typemap View 1 chunk +0 lines, -16 lines 0 comments Download
D components/network_hints/public/cpp/network_hints_param_traits.h View 1 chunk +0 lines, -31 lines 0 comments Download
D components/network_hints/public/cpp/network_hints_param_traits.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D components/network_hints/public/interfaces/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D components/network_hints/public/interfaces/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/network_hints/public/interfaces/network_hints.mojom View 1 chunk +0 lines, -22 lines 0 comments Download
M components/network_hints/renderer/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/network_hints/renderer/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M components/network_hints/renderer/renderer_dns_prefetch.h View 3 chunks +0 lines, -9 lines 0 comments Download
M components/network_hints/renderer/renderer_dns_prefetch.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M components/network_hints/renderer/renderer_preconnect.h View 2 chunks +0 lines, -6 lines 0 comments Download
M components/network_hints/renderer/renderer_preconnect.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M components/typemaps.gni View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/fuzzer.cc View 1 chunk +9 lines, -0 lines 0 comments Download
D tools/ipc_fuzzer/message_lib/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/ipc_fuzzer/message_lib/all_messages.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
tibell
Created Revert of Convert network hints to Mojo
4 years, 5 months ago (2016-07-24 23:52:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179693002/1
4 years, 5 months ago (2016-07-24 23:52:03 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-24 23:52:05 UTC) #5
Sam McNally
lgtm
4 years, 5 months ago (2016-07-24 23:52:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179693002/1
4 years, 5 months ago (2016-07-24 23:52:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/224009)
4 years, 5 months ago (2016-07-24 23:58:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2179693002/1
4 years, 5 months ago (2016-07-25 00:09:52 UTC) #14
commit-bot: I haz the power
Failed to apply patch for components/network_hints/browser/network_hints_impl.cc: While running git rm components/network_hints/browser/network_hints_impl.cc; fatal: pathspec 'components/network_hints/browser/network_hints_impl.cc' did ...
4 years, 5 months ago (2016-07-25 01:02:26 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 01:04:01 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0773f761ce9ed103aa297808ac89771bc010d70c
Cr-Commit-Position: refs/heads/master@{#407395}

Powered by Google App Engine
This is Rietveld 408576698