third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h - Issue 2179683002: [DevTools] Cleanup v8_inspector API part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

Issue 2179683002: [DevTools] Cleanup v8_inspector API part 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h » ('j') | third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

index 3747f66707d0513b68c6dae619d539343039144e..8b9a9531925c468385b0a7398187f513bea655a3 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

@@ -24,7 +24,6 @@ public:

virtual void unmuteWarningsAndDeprecations(int contextGroupId) = 0;

pfeldman 2016/07/25 17:33:30 ditto

virtual void beginUserGesture() = 0;

virtual void endUserGesture() = 0;

- virtual bool callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target) = 0;

virtual String16 valueSubtype(v8::Local<v8::Value>) = 0;

virtual bool formatAccessorsAsProperties(v8::Local<v8::Value>) = 0;

virtual bool isExecutionAllowed() = 0;

pfeldman 2016/07/25 17:33:29 You have a TODO to remove this.

@@ -33,6 +32,8 @@ public:

virtual bool isInspectableHeapObject(v8::Local<v8::Object>) = 0;

pfeldman 2016/07/25 17:33:29 I'd rather optionally install implementation of th

virtual void enableAsyncInstrumentation() = 0;

pfeldman 2016/07/25 17:33:30 I don't think we save anything with these, lets re

virtual void disableAsyncInstrumentation() = 0;

pfeldman 2016/07/25 17:33:30 ditto

+ virtual void beginEnsureAllContextsInGroup(int contextGroupId) = 0;

pfeldman 2016/07/25 17:33:30 I don't get what it does from its name.

+ virtual void endEnsureAllContextsInGroup(int contextGroupId) = 0;

virtual void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) = 0;