Allow getField of methods.

Allow getField of methods.

BUG= http://dartbug.com/13002
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34598

[floitsch, 2014-03-31 13:42:33]

Still needs tests.

[floitsch, 2014-03-31 20:12:00]

Tests added.

https://codereview.chromium.org/217963002/diff/40001/sdk/lib/_internal/lib/js...
File sdk/lib/_internal/lib/js_helper.dart (right):

https://codereview.chromium.org/217963002/diff/40001/sdk/lib/_internal/lib/js...
sdk/lib/_internal/lib/js_helper.dart:2038: JS('', '#["call*"] = #', prototype,
trampoline);
I think this was always wrong, and just never hit.
When we go through the call* of a tear-off we don't want to provide the receiver
(which would be the case for `function`).

[karlklose, 2014-04-01 08:32:23]

LGTM.

https://codereview.chromium.org/217963002/diff/40001/sdk/lib/_internal/compil...
File
sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart
(right):

https://codereview.chromium.org/217963002/diff/40001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart:129:
// If it is a method, it meight also have a tear-off closure.
'meight' -> 'may/might'.

https://codereview.chromium.org/217963002/diff/40001/sdk/lib/_internal/lib/js...
File sdk/lib/_internal/lib/js_helper.dart (right):

https://codereview.chromium.org/217963002/diff/40001/sdk/lib/_internal/lib/js...
sdk/lib/_internal/lib/js_helper.dart:187: //    in init.interceptedNames.
Align indentation with TODO above.

https://codereview.chromium.org/217963002/diff/40001/sdk/lib/_internal/lib/js...
sdk/lib/_internal/lib/js_helper.dart:221: // function is reflectable.
Perhaps we should add a failing test to make sure we fix this.

https://codereview.chromium.org/217963002/diff/40001/tests/lib/mirrors/invoke...
File tests/lib/mirrors/invoke_closurization2_test.dart (right):

https://codereview.chromium.org/217963002/diff/40001/tests/lib/mirrors/invoke...
tests/lib/mirrors/invoke_closurization2_test.dart:1: // Copyright (c) 2013, the
Dart project authors.  Please see the AUTHORS file
2013 -> 2014.

https://codereview.chromium.org/217963002/diff/40001/tests/lib/mirrors/invoke...
tests/lib/mirrors/invoke_closurization2_test.dart:17: //----------
Delete this line?

https://codereview.chromium.org/217963002/diff/40001/tests/lib/mirrors/invoke...
tests/lib/mirrors/invoke_closurization2_test.dart:54: confuse(0);
Why these calls?

[floitsch, 2014-04-01 14:03:19]

https://codereview.chromium.org/217963002/diff/40001/sdk/lib/_internal/compil...
File
sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart
(right):

https://codereview.chromium.org/217963002/diff/40001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart:129:
// If it is a method, it meight also have a tear-off closure.
On 2014/04/01 08:32:23, karlklose wrote:
> 'meight' -> 'may/might'.

Done.

https://codereview.chromium.org/217963002/diff/40001/sdk/lib/_internal/lib/js...
File sdk/lib/_internal/lib/js_helper.dart (right):

https://codereview.chromium.org/217963002/diff/40001/sdk/lib/_internal/lib/js...
sdk/lib/_internal/lib/js_helper.dart:187: //    in init.interceptedNames.
On 2014/04/01 08:32:23, karlklose wrote:
> Align indentation with TODO above.

Done.

https://codereview.chromium.org/217963002/diff/40001/sdk/lib/_internal/lib/js...
sdk/lib/_internal/lib/js_helper.dart:221: // function is reflectable.
On 2014/04/01 08:32:23, karlklose wrote:
> Perhaps we should add a failing test to make sure we fix this.

Filed 17939 and added test.

https://codereview.chromium.org/217963002/diff/40001/tests/lib/mirrors/invoke...
File tests/lib/mirrors/invoke_closurization2_test.dart (right):

https://codereview.chromium.org/217963002/diff/40001/tests/lib/mirrors/invoke...
tests/lib/mirrors/invoke_closurization2_test.dart:1: // Copyright (c) 2013, the
Dart project authors.  Please see the AUTHORS file
On 2014/04/01 08:32:23, karlklose wrote:
> 2013 -> 2014.

Done.

https://codereview.chromium.org/217963002/diff/40001/tests/lib/mirrors/invoke...
tests/lib/mirrors/invoke_closurization2_test.dart:17: //----------
On 2014/04/01 08:32:23, karlklose wrote:
> Delete this line?

Done.

https://codereview.chromium.org/217963002/diff/40001/tests/lib/mirrors/invoke...
tests/lib/mirrors/invoke_closurization2_test.dart:54: confuse(0);
On 2014/04/01 08:32:23, karlklose wrote:
> Why these calls?

Initially the recursive confuse call was recursing with 'x'. Now that it
reinvokes the DateTime constructor the inferrer will be lost anyways. Removed.

[floitsch, 2014-04-01 14:04:59]

Committed patchset #5 manually as r34598 (presubmit successful).