Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: content/public/browser/android/content_view_core.h

Issue 2179563003: Android: Remove ContentViewCore::GetLayer() from public interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/android/content_view_core.h
diff --git a/content/public/browser/android/content_view_core.h b/content/public/browser/android/content_view_core.h
index 24f9572853662750f9b1715a6211dafd33af74bd..588809574be90475e4629caab178350020e9db22 100644
--- a/content/public/browser/android/content_view_core.h
+++ b/content/public/browser/android/content_view_core.h
@@ -31,14 +31,12 @@ namespace content {
class WebContents;
-// Native side of the ContentViewCore.java, which is the primary way of
-// communicating with the native Chromium code on Android. This is a
-// public interface used by native code outside of the content module.
+// DEPRECATED. Do not add methods.
+// Refer to the public WebContents interface or elsewhere instead.
class CONTENT_EXPORT ContentViewCore {
public:
// Returns the existing ContentViewCore for |web_contents|, or nullptr.
static ContentViewCore* FromWebContents(WebContents* web_contents);
- static ContentViewCore* GetNativeContentViewCore(JNIEnv* env, jobject obj);
virtual WebContents* GetWebContents() const = 0;
@@ -51,7 +49,6 @@ class CONTENT_EXPORT ContentViewCore {
virtual ui::WindowAndroid* GetWindowAndroid() const = 0;
virtual const base::android::JavaRef<jobject>& GetViewAndroidDelegate()
const = 0;
- virtual cc::Layer* GetLayer() const = 0;
protected:
~ContentViewCore() {}
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698